fix: #3018 - UpToDateProductProvider now field of LocalDatabase #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atabase Impacted files: * `add_basic_details_page.dart`: got rid of `UpToDateProductProvider` * `add_new_product_page.dart`: got rid of `UpToDateProductProvider` * `edit_ingredients_page.dart`: got rid of `UpToDateProductProvider` * `edit_product_page.dart`: got rid of `UpToDateProductProvider` * `knowledge_panel_page.dart`: got rid of `UpToDateProductProvider` * `local_database.dart`: added an `UpToDateProductProvider` field * `main.dart`: got rid of `UpToDateProductProvider` * `new_product_page.dart`: got rid of `UpToDateProductProvider` * `nutrition_page_loaded.dart`: got rid of `UpToDateProductProvider` * `personalized_ranking_model.dart`: got rid of `UpToDateProductProvider` * `personalized_ranking_page.dart`: got rid of `UpToDateProductProvider` * `Podfile.lock`: wtf * `product_image_gallery_view.dart`: got rid of `UpToDateProductProvider` * `product_list_item_simple.dart`: got rid of `UpToDateProductProvider` * `product_list_page.dart`: got rid of `UpToDateProductProvider` * `product_refresher.dart`: got rid of `UpToDateProductProvider` * `simple_input_page.dart`: got rid of `UpToDateProductProvider` * `summary_card.dart`: got rid of `UpToDateProductProvider` * `up_to_date_product_provider.dart`: not a provider anymore; using `LocalDatabase` instead
github-actions
bot
added
database
✏️ Editing - Nutrition input
Product addition
M123-dev
approved these changes
Oct 27, 2022
Comment on lines
-15
to
21
| void set( | ||
| final Product product, { | ||
| final bool notify = true, | ||
| }) { | ||
| void set(final Product product) { | ||
| _map[product.barcode!] = product; | ||
| _timestamps[product.barcode!] = LocalDatabase.nowInMillis(); | ||
| if (notify) { | ||
| notifyListeners(); | ||
| } | ||
| localDatabase.notifyListeners(); | ||
| } |
There was a problem hiding this comment.
I don't know what exactly we used notify=false but we have to check that
Impacted files: * `product_list_page.dart`: format after merge conflict fix
AshAman999
reviewed
Oct 27, 2022
There was a problem hiding this comment.
Looks good, one question is there though
On the new product page screen, I tried adding a new product
- the button to go to nutrition edit is disabled / hidden as the image is not yet uploaded
- I upload the photo and let it finish in the background
- After a few moments it's still not visible though the task of uploading photos is already done
Not sure if the contents of the page refreshed after the background task completed
I am not sure if the pages refreshed after we are done with the background task,
Since we are not using consumers , is that causing so ?
|
Thank you @M123-dev for your review! |
|
@AshAman999 I did nothing regarding the background tasks in this PR, it was just the first step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
add_basic_details_page.dart: got rid ofUpToDateProductProvideradd_new_product_page.dart: got rid ofUpToDateProductProvideredit_ingredients_page.dart: got rid ofUpToDateProductProvideredit_product_page.dart: got rid ofUpToDateProductProviderknowledge_panel_page.dart: got rid ofUpToDateProductProviderlocal_database.dart: added anUpToDateProductProviderfieldmain.dart: got rid ofUpToDateProductProvidernew_product_page.dart: got rid ofUpToDateProductProvidernutrition_page_loaded.dart: got rid ofUpToDateProductProviderpersonalized_ranking_model.dart: got rid ofUpToDateProductProviderpersonalized_ranking_page.dart: got rid ofUpToDateProductProviderPodfile.lock: wtfproduct_image_gallery_view.dart: got rid ofUpToDateProductProviderproduct_list_item_simple.dart: got rid ofUpToDateProductProviderproduct_list_page.dart: got rid ofUpToDateProductProviderproduct_refresher.dart: got rid ofUpToDateProductProvidersimple_input_page.dart: got rid ofUpToDateProductProvidersummary_card.dart: got rid ofUpToDateProductProviderup_to_date_product_provider.dart: not a provider anymore; usingLocalDatabaseinsteadWhat
UpToDateProductProviderfield ofLocalDatabase.LocalDatabasebut notUpToDateProductProvider.notifyingLocalDatabase.Part of