fix: 3663 - packaging number of units and weight as nums #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `simple_input_number_field.dart`: Simple input text field, for numbers. * `simple_input_text_field.dart`: Simple input text field, with autocompletion. Used to be in `simple_input_widget.dart` Impacted files: * `edit_new_packagings.dart`: minor refactoring * `edit_new_packagings_component.dart`: now we use a numeric keyboard for number of units and weight * `edit_new_packagings_helper.dart`: now we format and parse number of units as int? and weight as double? * `nutrition_page_loaded.dart`: minor refactoring * `simple_input_widget.dart`: refactored code to new file `simple_input_text_field.dart`
github-actions
bot
added
✏️ Editing - Nutrition input
✏️ Editing - Packaging input
Codecov Report
@@ Coverage Diff @@
## develop #3676 +/- ##
==========================================
- Coverage 9.42% 9.38% -0.05%
==========================================
Files 269 271 +2
Lines 13611 13675 +64
==========================================
Hits 1283 1283
- Misses 12328 12392 +64
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you @monsieurtanuki ! |
M123-dev
approved these changes
Feb 8, 2023
|
Thank you @M123-dev for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New files:
simple_input_number_field.dart: Simple input text field, for numbers.simple_input_text_field.dart: Simple input text field, with autocompletion. Used to be insimple_input_widget.dartImpacted files:
edit_new_packagings.dart: minor refactoringedit_new_packagings_component.dart: now we use a numeric keyboard for number of units and weightedit_new_packagings_helper.dart: now we format and parse number of units as int? and weight as double?nutrition_page_loaded.dart: minor refactoringsimple_input_widget.dart: refactored code to new filesimple_input_text_field.dartWhat
nullif we cannot parse, but it's far more unlikely.Screenshot
Fixes bug(s)