feat: 3749 - improvements for packaging suggestions #3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ad46236.
# Conflicts: # packages/smooth_app/pubspec.lock # packages/smooth_app/pubspec.yaml
Impacted files: * `edit_new_packagings.dart`: added categories parameter for suggestions * `edit_new_packagings_component.dart`: added categories field; added categories parameters for shape search; added categories and shape parameters for material search; added specific minLengthForSuggestions parameter set to 0 for shape and material search * `simple_input_text_field.dart`: added minLengthForSuggestions, categories and shape fields; added categories, shape and country parameters for `getSuggestions`
github-actions
bot
added
✏️ Editing - Packaging input
Codecov Report
@@ Coverage Diff @@
## develop #3750 +/- ##
===========================================
- Coverage 10.41% 10.40% -0.01%
===========================================
Files 272 272
Lines 13824 13835 +11
===========================================
Hits 1440 1440
- Misses 12384 12395 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks a lot @monsieurtanuki , this will speed up entry of packagings quite a bit! |
thomas-algo
added a commit
to thomas-algo/smooth-app
that referenced
this pull request
Feb 28, 2023
@monsieurtanuki as addressed the issue in openfoodfacts#3750 without disturbing old default behavior of the widget.
@stephanegigandet Don't hesitate to create a new issue in order to make the entry of packagings even smoother. |
stephanegigandet
approved these changes
Feb 28, 2023
|
Thank you @stephanegigandet for the review! |
monsieurtanuki
added a commit
that referenced
this pull request
Mar 2, 2023
… size of the autocomplete tab. (#3744) * Updated the preview of the package in the 'Packaging components ' tab. Preview is now clearer and more coherent with what is shown on the product page. * Autocomplete now gives hints before anything is typed & maxOptionsHeight fixed - The autocomplete now gives the most common answers for the field before user start typing. (Useful for packaging material, recycling...) - Fixing _AssertionError 'maxOptionsHeight >= 0': is not true: The old formula could give negative values. It could also create an unreadable autocomplete if the field was too close to the keyboard. * Removed Autocomplete now gives hints before anything is typed. @monsieurtanuki as addressed the issue in #3750 without disturbing old default behavior of the widget. * Comment explaining the limit of suggestions. * Taking into account the case 'Material empty' and 'Weight not empty' & format * Removing unused variables This variables where previously used in the formula of maxOptionsHeight * Update packages/smooth_app/lib/pages/product/edit_new_packagings_helper.dart --------- Co-authored-by: monsieurtanuki <fabrice_fontaine@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
edit_new_packagings.dart: added categories parameter for suggestionsedit_new_packagings_component.dart: added categories field; added categories parameters for shape search; added categories and shape parameters for material search; added specific minLengthForSuggestions parameter set to 0 for shape and material searchsimple_input_text_field.dart: added minLengthForSuggestions, categories and shape fields; added categories, shape and country parameters forgetSuggestionsWhat
Fixes bug(s)