Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Camera awesome #3790

Merged
merged 9 commits into from
Mar 21, 2023
Merged

feat: Camera awesome #3790

merged 9 commits into from
Mar 21, 2023

Conversation

M123-dev
Copy link
Member

What

Just adding this in here with the possibility of it getting removed in a few days. An alternative implementation of camerawesome together with ML Kit.

  • It needs some more work, we have to manually trigger the analysis
  • It needs some further work, when pushing above it the camera is not paused automatically
  • So why did I even decide to open the PR, there is a somewhat stale discussion about the carousel and if that is the best use of the scanner, but no matter what it boils down to we'll likely need the scanner to focus on the top part and not necessarily remove the camera from the bottom of the page completely, using a dedicated camera package likely allows for more freedom to do such things. c.f. my issue Move focus point Apparence-io/CamerAwesome#272

@M123-dev M123-dev requested a review from a team as a code owner March 20, 2023 17:15
@github-actions github-actions bot added dependencies 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… labels Mar 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Merging #3790 (1e52a18) into develop (08fd134) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3790      +/-   ##
===========================================
- Coverage    10.78%   10.67%   -0.11%     
===========================================
  Files          269      272       +3     
  Lines        13405    13541     +136     
===========================================
  Hits          1446     1446              
- Misses       11959    12095     +136     
Impacted Files Coverage Δ
...b/pages/preferences/user_preferences_dev_mode.dart 0.00% <ø> (ø)
.../lib/pages/scan/awesome_widgets/awesome_flash.dart 0.00% <0.00%> (ø)
...es/smooth_app/lib/pages/scan/camera_scan_page.dart 2.00% <0.00%> (-0.18%) ⬇️
packages/smooth_app/lib/pages/scan/scan_page.dart 2.94% <0.00%> (-0.14%) ⬇️
...lib/pages/scan/smooth_barcode_scanner_awesome.dart 0.00% <0.00%> (ø)
...p/lib/pages/scan/smooth_barcode_scanner_visor.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @M123-dev!
I'm not sure where this will lead, but we're in a kind of testing period so let's try!
I must say I'm a bit reluctant as there's a big fat chance that I won't be able to compile the app on my smartphone anymore given the packages you're adding. Well, at least I was able to use the app one month, could be worse ;)

@M123-dev
Copy link
Member Author

Thanks for your review @monsieurtanuki, I applied your suggestions

@M123-dev M123-dev merged commit 5c95929 into develop Mar 21, 2023
@M123-dev M123-dev deleted the camera_awesome branch March 21, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android dependencies 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Development

Successfully merging this pull request may close these issues.

None yet

3 participants