-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Camera awesome #3790
feat: Camera awesome #3790
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3790 +/- ##
===========================================
- Coverage 10.78% 10.67% -0.11%
===========================================
Files 269 272 +3
Lines 13405 13541 +136
===========================================
Hits 1446 1446
- Misses 11959 12095 +136
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @M123-dev!
I'm not sure where this will lead, but we're in a kind of testing period so let's try!
I must say I'm a bit reluctant as there's a big fat chance that I won't be able to compile the app on my smartphone anymore given the packages you're adding. Well, at least I was able to use the app one month, could be worse ;)
packages/smooth_app/lib/pages/scan/awesome_widgets.dart/awesome_flash.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/scan/smooth_barcode_scanner_awesome.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/scan/smooth_barcode_scanner_awesome.dart
Outdated
Show resolved
Hide resolved
Thanks for your review @monsieurtanuki, I applied your suggestions |
What
Just adding this in here with the possibility of it getting removed in a few days. An alternative implementation of camerawesome together with ML Kit.