Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Android signing config #3793

Merged
merged 1 commit into from
Mar 21, 2023
Merged

fix: Android signing config #3793

merged 1 commit into from
Mar 21, 2023

Conversation

M123-dev
Copy link
Member

What

I have wrongly committed a local change for testing. Of course, we should use the singing identity for the release and due to that the android release is failing at the moment

@M123-dev M123-dev requested a review from a team as a code owner March 21, 2023 18:23
@M123-dev M123-dev added Android fastlane Automation of releases and marketing assets deployment labels Mar 21, 2023
@github-actions github-actions bot removed the fastlane Automation of releases and marketing assets deployment label Mar 21, 2023
@M123-dev
Copy link
Member Author

( On a sidenote:
@monsieurtanuki could you create some as you like to call them "wtf" changes, due to the ML kit library the iOS release is failing aswell

Analyzing dependencies
[!] CocoaPods could not find compatible versions for pod "GoogleMLKit/BarcodeScanning":
  In snapshot (Podfile.lock):
    GoogleMLKit/BarcodeScanning (= 2.6.0, ~> 2.6.0)

  In Podfile:
    google_mlkit_barcode_scanning (from `.symlinks/plugins/google_mlkit_barcode_scanning/ios`) was resolved to 0.5.0, which depends on
      GoogleMLKit/BarcodeScanning (~> 3.2.0)


You have either:
 * changed the constraints of dependency `GoogleMLKit/BarcodeScanning` inside your development pod `google_mlkit_barcode_scanning`.
   You should run `pod update GoogleMLKit/BarcodeScanning` to apply changes you've made.

I think the podfile.lock should get regenerated by a flutter run or pub get on a mac

@M123-dev
Copy link
Member Author

Also thanks for the quick review, faster than the tests 😄

@M123-dev M123-dev merged commit 5849ece into develop Mar 21, 2023
@M123-dev M123-dev deleted the fix-Android-signing-config branch March 21, 2023 18:28
@monsieurtanuki
Copy link
Contributor

@M123-dev
As is:

% pod update GoogleMLKit/BarcodeScanning
Updating local specs repositories
Analyzing dependencies
[!] CocoaPods could not find compatible versions for pod "MLKitCommon":
  In Podfile:
    google_mlkit_barcode_scanning (from `.symlinks/plugins/google_mlkit_barcode_scanning/ios`) was resolved to 0.5.0, which depends on
      GoogleMLKit/BarcodeScanning (~> 3.2.0) was resolved to 3.2.0, which depends on
        GoogleMLKit/MLKitCore (= 3.2.0) was resolved to 3.2.0, which depends on
          MLKitCommon (~> 8.0.0)

    google_mlkit_commons (from `.symlinks/plugins/google_mlkit_commons/ios`) was resolved to 0.2.0, which depends on
      MLKitVision was resolved to 3.0.0, which depends on
        MLKitCommon (~> 5.0)

Then I upgraded "my" mlkit to 3.1.1 and downgraded "your" mlkit to 0.4.0, but the versions still do not match:

% pod update GoogleMLKit/BarcodeScanning
Updating local specs repositories
Analyzing dependencies
[!] CocoaPods could not find compatible versions for pod "GoogleMLKit/BarcodeScanning":
  In Podfile:
    google_mlkit_barcode_scanning (from `.symlinks/plugins/google_mlkit_barcode_scanning/ios`) was resolved to 0.4.0, which depends on
      GoogleMLKit/BarcodeScanning (~> 3.1.0)

    mobile_scanner (from `.symlinks/plugins/mobile_scanner/ios`) was resolved to 3.0.0, which depends on
      GoogleMLKit/BarcodeScanning (~> 3.2.0)

@monsieurtanuki
Copy link
Contributor

@M123-dev Thank you btw for your comment on zxing. Not sure if it will be enough.

Fun fact: in French, "planned obsolescence" is called "programmed obsolescence" ("obsolescence programmée"), and indeed it's programmed inside zxing.

@M123-dev
Copy link
Member Author

Thank you btw for your comment on zxing. Not sure if it will be enough.

Hopefully, but it doesn't seem like it, but mobile_scanner on the other hand for older macOS versions does

@M123-dev
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants