fix: 3816 - commented camerawesome

[monsieurtanuki]

Impacted files:

• awesome_flash.dart: commented everything
• camera_scan_page.dart: commented references to camerawesome
• Info.plist: wtf
• Podfile.lock: wtf
• project.pbxproj: wtf
• pubspec.lock: wtf
• pubspec.yaml: commented camerawesome and google_mlkit_barcode_scanning
• smooth_barcode_scanner_awesome.dart: commented everything
• smooth_barcode_scanner_visor.dart: commented everything

What

• There were recent changes regarding the barcode scanners/flutter 3.7 (feat: 3712 - new mlkit and zxing scanners on flutter 3.7 #3767), and the focus (haha) was on android devices.
• The results were good. Good enough to merge and upgrade to flutter 3.7.
• Unfortunately, we didn't test on ios, and it looks like some minor language version issues (in mobile_scanner) prevent us from even compiling (iOS build is failing due to mobile_scanner #3780).
• I PR'ed some fixes in fix: 544 - explicit returned type for compactMap juliansteenbakker/mobile_scanner#568, and those fixes need to be tested "for real".
• Unfortunately it's not possible to test everything on my macbook because apple basterds are big fans of planned obsolescence.
• In addition to that, @M123-dev added another layer of complexity by adding a barcode scanner (let's call it "camerawesome"). That was an appropriate timing because we were in a "test new barcode scanner options" phase. Unfortunately, this causes other ios compilation issues, which looks like incompatible mlkit versions.
• The purpose of the current PR is to:
  • deactivate the brand new "camerawesome" code
  • in order to test the mobile_scanner PR without "camerawesome" turbulences
  • and hopefully give a "go for it!" to @juliansteenbakker
• Once the tests are OK, we can put back the "camerawesome" code if relevant, assuming that we can fix the mlkit versions incompabilities

Part of

• The iOS release is blocked #3816

[M123-dev]

I'm okay with commenting it out👍🏻

Lets hope it works

[monsieurtanuki]

Thank you very much @M123-dev!
We'll see what happens.

[monsieurtanuki]

@M123-dev I didn't work this time either.
It looks like the command for ios is (edited version):

cd ./packages/smooth_app
cd ios
pod update Sentry
cd ..
flutter build ios --release --no-codesign -t lib/entrypoints/ios/main_ios.dart

We have the same error message:

Updating local specs repositories
Adding spec repo `trunk` with CDN `[https://cdn.cocoapods.org/`](https://cdn.cocoapods.org/%60)
Analyzing dependencies
[!] CocoaPods could not find compatible versions for pod "GoogleMLKit/BarcodeScanning":
  In snapshot (Podfile.lock):
    GoogleMLKit/BarcodeScanning (= 3.2.0, ~> 3.2.0)

  In Podfile:
    mobile_scanner (from `.symlinks/plugins/mobile_scanner/ios`) was resolved to 3.2.0, which depends on
      GoogleMLKit/BarcodeScanning (~> 4.0.0)


You have either:
 * changed the constraints of dependency `GoogleMLKit/BarcodeScanning` inside your development pod `mobile_scanner`.
   You should run `pod update GoogleMLKit/BarcodeScanning` to apply changes you've made.

It looks like GoogleMLKit/BarcodeScanning is a pain in the neck, like Sentry.
Would it be possible to add a specific refresh in the command list of the ios build?

cd ./packages/smooth_app
cd ios
pod update Sentry
pod update GoogleMLKit/BarcodeScanning
cd ..
flutter build ios --release --no-codesign -t lib/entrypoints/ios/main_ios.dart

[monsieurtanuki]

ping @teolemon: btw if think you too have access to the CI/CD settings.

[juliansteenbakker]

@monsieurtanuki if you change the following in the pubspec, it will work. Please keep in mind that you should still fix the dependency issue by either forking & upgrading the camerawesome package in order to use the latest version of the mlkit library for ios.

  mobile_scanner:
    git:
      url: https://github.com/juliansteenbakker/mobile_scanner.git
      ref: master

to

  mobile_scanner:
    git:
      url: https://github.com/juliansteenbakker/mobile_scanner.git
      ref: ios-mlkit-3.2.0

[monsieurtanuki]

Thank you @juliansteenbakker for your suggestion.
I will try it if what I've just tried in #3832 fails.