Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Clear all" button on Nutritional info #3978

Open
Tracked by #511
g123k opened this issue May 18, 2023 · 5 comments
Open
Tracked by #511

Add a "Clear all" button on Nutritional info #3978

g123k opened this issue May 18, 2023 · 5 comments

Comments

@g123k
Copy link
Collaborator

g123k commented May 18, 2023

Hi everyone,

As a contributor, I often have to change the nutritional values on existing products, due to new recipes.
In many cases, there are 2 digits to change for each field.

And on iOS, that's really a pain to edit each value.
If we could instead clear all the data, it would be a far better UX.

Part of

@g123k g123k changed the title Add a "Clear all" button on the Nutritional info Add a "Clear all" button on Nutritional info May 18, 2023
@teolemon
Copy link
Member

We can certainly add a "Clear all values". We have a similar button on the web version, I'm not completely sure we made it available to all users (potential for abuse)

@g123k
Copy link
Collaborator Author

g123k commented May 19, 2023

We can certainly add a "Clear all values". We have a similar button on the web version, I'm not completely sure we made it available to all users (potential for abuse)

What about a setting in the app? Disabled by default, but we can override it

@teolemon
Copy link
Member

LGTM

@g123k
Copy link
Collaborator Author

g123k commented Jan 29, 2024

I often have the case and the DEV mode would be frustrating, as nobody will ever use it.

However, here is a suggestion for a smarter implementation: if we detect that the user has changed let's say 2 or 3 items, in that case, we show a message (popup? icon?) asking if we want to clear the other fields in the screen.
So we will just clear, the items that HAVE NOT been edited yet

Just to be clear, only items that have not been edited will be emptied.
What do you think of this idea?

@teolemon
Copy link
Member

teolemon commented Jan 29, 2024

@g123k Sounds reasonable.
Eventually, we could leverage quality facets:

Even for new products, we could send values to a To be created™ route, that could send back potential errors and warnings in real time

EDIT: created an issue: openfoodfacts/openfoodfacts-server#9710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

2 participants