fix: 3980 - refresh of the ordered nutrients #3997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `ordered_nutrients_cache.dart`: now we cache the downloaded data in static - it used to be in database but then was never refreshed * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded openfoodfacts to 2.5.1
Codecov Report
@@ Coverage Diff @@
## develop #3997 +/- ##
========================================
Coverage 10.95% 10.95%
========================================
Files 266 266
Lines 13105 13103 -2
========================================
Hits 1435 1435
+ Misses 11670 11668 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
g123k
reviewed
May 23, 2023
g123k
approved these changes
May 23, 2023
|
thanks @monsieurtanuki, merging |
|
Thank you @g123k for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
Fixes bug(s)
Impacted files
ordered_nutrients_cache.dart: now we cache the downloaded data in static - it used to be in database but then was never refreshedpubspec.lock: wtfpubspec.yaml: upgraded openfoodfacts to 2.5.1