Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add a missing Material Widget in the history #4111

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 10, 2023

Hi everyone,

From the history, opening a product and then going back to the history generates an issue with a missing Material widget.
The fix is not that hard to implement.

Before: Before.webm

After: After.webm

@g123k g123k requested a review from a team as a code owner June 10, 2023 13:26
@g123k g123k self-assigned this Jun 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4111 (4cf8ff0) into develop (af9f28b) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #4111   +/-   ##
========================================
  Coverage    10.84%   10.84%           
========================================
  Files          273      273           
  Lines        13516    13512    -4     
========================================
  Hits          1466     1466           
+ Misses       12050    12046    -4     
Impacted Files Coverage Δ
...cards/product_cards/smooth_product_card_found.dart 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon
Copy link
Member

screen-20230609-211104.mp4

@g123k
Copy link
Collaborator Author

g123k commented Jun 10, 2023

screen-20230609-211104.mp4

It's another issue:

======== Exception caught by scheduler library =====================================================
The following assertion was thrown during a scheduler callback:
There are multiple heroes that share the same tag within a subtree.

Within each subtree for which heroes are to be animated (i.e. a PageRoute subtree), each Hero must have a unique non-null tag.
In this case, multiple heroes had the following tag: 0072392139514
Here is the subtree for one of the offending heroes: Hero
  tag: 0072392139514
  dependencies: [_ModalScopeStatus]
  state: _HeroState#d52c2
When the exception was thrown, this was the stack: 
#0      Hero._allHeroesFor.inviteHero.<anonymous closure> (package:flutter/src/widgets/heroes.dart:283:11)
#1      Hero._allHeroesFor.inviteHero (package:flutter/src/widgets/heroes.dart:294:8)
#2      Hero._allHeroesFor.visitor (package:flutter/src/widgets/heroes.dart:322:13)
#3      SingleChildRenderObjectElement.visitChildren (package:flutter/src/widgets/framework.dart:6363:14)
#4      Hero._allHeroesFor.visitor (package:flutter/src/widgets/heroes.dart:328:15)
#5      ComponentElement.visitChildren (package:flutter/src/widgets/framework.dart:5020:14)
#6      Hero._allHeroesFor.visitor (package:flutter/src/widgets/heroes.dart:328:15)
#7      ComponentElement.visitChildren (package:flutter/src/widgets/framework.dart:5020:14)

@teolemon teolemon changed the title Fix: Add a missing Material Widget in the history fix: Add a missing Material Widget in the history Jun 10, 2023
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a brief flash in my internal build, I guess that's it

@teolemon teolemon merged commit 6a8edbe into openfoodfacts:develop Jun 10, 2023
6 of 7 checks passed
@g123k g123k deleted the material_error branch June 11, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants