Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 4122 - added a country filter for hunger games #4168

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Without a filter on the country, hunger games suggested questions from all over the world - often France.
  • Now we filter products/questions by country.

Fixes bug(s)

Impacted files

  • pubspec.lock: wtf
  • pubspec.yaml: upgraded to off-dart 2.6.0
  • random_questions_query.dart: added a country filter for hunger games

Impacted files:
* `pubspec.lock`: wtf
* `pubspec.yaml`: upgraded to off-dart 2.6.0
* `random_questions_query.dart`: added a country filter for hunger games
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving like this, but Hunger Games users like to swap countries directly from the screen game. Changing it at app level is a big commitment

@monsieurtanuki monsieurtanuki merged commit 79ec954 into openfoodfacts:develop Jun 15, 2023
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review!

I'm approving like this, but Hunger Games users like to swap countries directly from the screen game. Changing it at app level is a big commitment

As a modest and recent French Hunger Games user, I wouldn't say I enjoyed that much answering questions from a picture of a packaging in another language, e.g. looking for the German translation of "flour".
It used to be total random.

An improvement would be to make it possible for (advanced) users to

  • select the Hunger Games country for the next questions
  • filter by insight type (e.g. "category")
  • sort by descending popularity instead of random

Please create a dedicated issue if relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Country filter needed for Hunger Games
2 participants