Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 3843 - matomo for new product page #4217

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

Now we track with matomo the following events regarding the "add new product" page:

  1. opening the page
  2. closing the page without any input
  3. setting the category
  4. setting the ingredients
  5. setting the nutrition facts
  6. uploading at least one image

Fixes bug(s)

Impacted files

  • add_new_product_page.dart: implemented the tracking of 6 events for matomo
  • analytics_helper.dart: added 1 category and 6 related events for the "new product page"

Impacted files:
* `add_new_product_page.dart`: implemented the tracking of 6 events for matomo
* `analytics_helper.dart`: added 1 category and 6 related events for the "new product page"
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner June 20, 2023 09:18
@github-actions github-actions bot added 📈 Analytics We use Sentry and Matomo, with an opt-in system Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page labels Jun 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

Merging #4217 (ee3a747) into develop (42b8788) will increase coverage by 0.31%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4217      +/-   ##
===========================================
+ Coverage    10.88%   11.20%   +0.31%     
===========================================
  Files          277      277              
  Lines        13600    13775     +175     
===========================================
+ Hits          1481     1543      +62     
- Misses       12119    12232     +113     
Impacted Files Coverage Δ
...kages/smooth_app/lib/helpers/analytics_helper.dart 0.00% <ø> (ø)
...th_app/lib/pages/product/add_new_product_page.dart 0.00% <0.00%> (ø)

... and 30 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @monsieurtanuki 👌

@monsieurtanuki monsieurtanuki merged commit 7ac86dc into openfoodfacts:develop Jun 20, 2023
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Analytics We use Sentry and Matomo, with an opt-in system 📈 Matomo Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page
Development

Successfully merging this pull request may close these issues.

Instrument opening the product addition screen in Matomo
4 participants