fix: 4176 - border for some edit image buttons #4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `edit_image_button.dart`: added an optional border * `edit_ocr_page.dart`: unrelated add of "logged in?" parameter * `product_field_editor.dart`: unrelated add of a "logged in?" parameter * `product_image_local_button.dart`: added an optional border and a "logged in?" parameter * `product_image_server_button.dart`: added an optional border and a "logged in?" parameter; added a test if display is relevant * `product_image_viewer.dart`: added a "logged in?" parameter
Codecov Report
@@ Coverage Diff @@
## develop #4218 +/- ##
===========================================
+ Coverage 10.88% 11.21% +0.32%
===========================================
Files 277 277
Lines 13600 13763 +163
===========================================
+ Hits 1481 1543 +62
- Misses 12119 12220 +101
... and 31 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
teolemon
reviewed
Jun 20, 2023
Impacted file: * `edit_image_button.dart`: colors and padding slight change
|
With the latest push
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Now in the OCR pages
Screenshot
Fixes bug(s)
Impacted files
edit_image_button.dart: added an optional borderedit_ocr_page.dart: unrelated add of "logged in?" parameterproduct_field_editor.dart: unrelated add of a "logged in?" parameterproduct_image_local_button.dart: added an optional border and a "logged in?" parameterproduct_image_server_button.dart: added an optional border and a "logged in?" parameter; added a test if display is relevantproduct_image_viewer.dart: added a "logged in?" parameter