feat: 3919 - select languages for new product images

[monsieurtanuki]

What

• In the "add new product" page, we now have the possibility to select the language of the uploaded picture.
• We do that by reusing the same edit image screen as in existing products.

Screenshot

No changes actually here

new product found!	new product edit page

Click on an "edit image" button

no picture so far	picture selected for French

Same product, in Dutch

what about Dutch?	picture uploaded for Dutch

picture in 2 languages	picture considered uploaded

Fixes bug(s)

• Closes: Allow to pick photo language when uploading a new product #3919

Files

New file:

• add_new_product_helper.dart: Helper classes for AddNewProductPage that was getting too big.

Impacted files:

• add_basic_details_page.dart: minor refactoring
• add_new_product_page.dart: moved code to new file add_new_product_helper.dart; refactored the trackers with new class AnalyticsProductTracker; refactored the access to image edit
• add_simple_input_button.dart: minor refactoring
• crop_page.dart: minor refactoring
• edit_new_packagings.dart: minor refactoring
• edit_ocr_page.dart: minor refactoring
• edit_product_page.dart: minor refactoring
• image_crop_page.dart: minor refactoring
• image_field_extension.dart: minor refactoring
• nutrition_page_loaded.dart: minor refactoring
• product_cards_helper.dart: minor refactoring
• product_field_editor.dart: minor refactoring
• product_image_carousel.dart: minor refactoring
• product_image_carousel_item.dart: renamed from image_upload_card.dart
• product_image_gallery_view.dart: minor refactoring
• product_image_local_button.dart: minor refactoring
• product_image_server_button.dart: minor refactoring
• product_image_swipeable_view.dart: minor refactoring
• product_image_viewer.dart: minor refactoring
• product_refresher.dart: minor refactoring
• uploaded_image_gallery.dart: minor refactoring

[codecov-commenter]

Codecov Report

Merging #4255 (2ddb97f) into develop (b84cd3c) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4255      +/-   ##
===========================================
- Coverage    10.31%   10.27%   -0.04%     
===========================================
  Files          296      297       +1     
  Lines        15431    15487      +56     
===========================================
  Hits          1591     1591              
- Misses       13840    13896      +56     

Files Changed	Coverage Δ
.../cards/data_cards/product_image_carousel_item.dart	0.00% <0.00%> (ø)
...ib/cards/product_cards/product_image_carousel.dart	0.00% <0.00%> (ø)
.../smooth_app/lib/helpers/image_field_extension.dart	0.00% <ø> (ø)
...s/smooth_app/lib/helpers/product_cards_helper.dart	0.00% <ø> (ø)
packages/smooth_app/lib/pages/crop_page.dart	0.00% <0.00%> (ø)
...th_app/lib/pages/image/uploaded_image_gallery.dart	0.00% <0.00%> (ø)
packages/smooth_app/lib/pages/image_crop_page.dart	0.79% <ø> (ø)
..._app/lib/pages/product/add_basic_details_page.dart	0.00% <0.00%> (ø)
..._app/lib/pages/product/add_new_product_helper.dart	0.00% <0.00%> (ø)
...th_app/lib/pages/product/add_new_product_page.dart	0.00% <0.00%> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[teolemon]

Does it mean the picker lets you multi select languages, and then prevent the thing from going green unless those 2 have 2 for each section ?

[monsieurtanuki]

Does it mean the picker lets you multi select languages, and then prevent the thing from going green unless those 2 have 2 for each section ?

No, the button goes green when there's at least one picture for this field (for one language).
The green button screenshot could have been just after the French input too. And you can click on a green button to add picture for other languages.

[g123k]

Before validating this PR,I would like #4315 to be merged, as not everyone can access the subfeature, so it's important to fix it first.

[teolemon]

Hey @monsieurtanuki I merged a bit too hastily
error • The named parameter 'isLoggedInMandatory' is required, but there's no corresponding argument • packages/smooth_app/lib/pages/product/edit_product_page.dart:236:49 • missing_required_argument

Can you fix it so that I can install the Waldo build to test it ?

[monsieurtanuki]

Can you fix it so that I can install the Waldo build to test it ?

Should be OK now.

[github-actions]

You can test this PR on: Android

[g123k]

@teolemon Could you test the feature?
Because as I break the screen in many pages, it would be better to merge this one first

[teolemon]

[g123k]

Argh, that's because #4438 was not merged

[monsieurtanuki]

@teolemon @g123k I've just updated the branch, should be OK then.

[monsieurtanuki]

@teolemon @g123k I've just updated the branch, should be OK then.

@g123k No way to refresh the waldo? Or is that refresh implicit?

[monsieurtanuki]

@teolemon ping

[teolemon]

thanks @monsieurtanuki , merging