feat: 3941 - refactoring about up-to-date product data for StatefulWidgets #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dgets New file: * `up_to_date_manager.dart`: Provides the most up-to-date local product data for a StatefulWidget. Impacted files: * `add_new_product_page.dart`: now using new class `UpToDateManager` * `edit_new_packagings.dart`: now using new class `UpToDateManager` * `edit_ocr_page.dart`: now using new class `UpToDateManager` * `edit_product_page.dart`: now using new class `UpToDateManager` * `knowledge_panel_page.dart`: now using new class `UpToDateManager` * `new_product_page.dart`: now using new class `UpToDateManager` * `nutrition_page_loaded.dart`: now using new class `UpToDateManager` * `product_image_gallery.dart`: now using new class `UpToDateManager` * `product_image_swipeable.dart`: now using new class `UpToDateManager` * `product_image_viewer.dart`: now using new class `UpToDateManager` * `summary_card.dart`: now using new class `UpToDateManager`
github-actions
bot
added
🥫 Product page
Product addition
Codecov Report
@@ Coverage Diff @@
## develop #4262 +/- ##
===========================================
+ Coverage 10.79% 10.82% +0.02%
===========================================
Files 287 288 +1
Lines 14288 14251 -37
===========================================
Hits 1542 1542
+ Misses 12746 12709 -37
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
g123k
reviewed
Jul 7, 2023
| /// * we get the most up-to-date local product data | ||
| /// * we re-launch the task manager if relevant | ||
| /// * we track the barcodes currently "opened" by the app | ||
| class UpToDateManager { |
There was a problem hiding this comment.
Why don't use a mixin here?
As it's specifically design for a StatefullWidget, it would simplify the integration
Otherwise, looks OK 👍
There was a problem hiding this comment.
@g123k Thank you for the suggestion! I edited the code in the latest push: my first experience with mixin.
Not 100% convinced in that particular case, specifically because we somehow need a constructor - replaced by an "init" method as mixin doesn't accept constructors.
In the end, it looks a bit better than before.
There was a problem hiding this comment.
I clearly prefer this implementation, even if indeed the number of lines is similar.
(I am also very sorry, I receive random notifications from GitHub, and I totally missed your answer)
g123k
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes bug(s)
Files
New file:
up_to_date_manager.dart: Provides the most up-to-date local product data for a StatefulWidget.Impacted files:
add_new_product_page.dart: now using new classUpToDateManageredit_new_packagings.dart: now using new classUpToDateManageredit_ocr_page.dart: now using new classUpToDateManageredit_product_page.dart: now using new classUpToDateManagerknowledge_panel_page.dart: now using new classUpToDateManagernew_product_page.dart: now using new classUpToDateManagernutrition_page_loaded.dart: now using new classUpToDateManagerproduct_image_gallery.dart: now using new classUpToDateManagerproduct_image_swipeable.dart: now using new classUpToDateManagerproduct_image_viewer.dart: now using new classUpToDateManagersummary_card.dart: now using new classUpToDateManager