fix: 4206 - search page misalignment in search-history_view.dart (#4210) #4266
Conversation
…nfoodfacts#4210) Impacted file: search-history_view.dart: added padding to the list tile for proper alignment Resolved the misalignment issue on the search page by adding appropriate padding to the list tile in the search-history_view.dart file. This adjustment ensures that the elements within the list are properly aligned, improving the visual consistency of the search page.
github-actions
bot
added
the
🤳🥫 Scan
|
Hello, thanks for your PR. |
|
Sorry mb, I will make the necessary changes |
|
Far better 👍 |
tanishq5414
force-pushed
the
develop
branch
2 times, most recently
from
5fddf47
to
c818bb1
Compare
github-actions
bot
removed
the
🤳🥫 Scan
…nfoodfacts#4210) Impacted file: search-history_view.dart: added padding to the list tile for proper alignment Resolved the misalignment issue on the search page by adding appropriate padding to the list tile in the search-history_view.dart file. This adjustment ensures that the elements within the list are properly aligned, improving the visual consistency of the search page.
github-actions
bot
added
the
🤳🥫 Scan
|
Hey, I have made the changes. Can you verify? |
|
Almost perfect, the Ripple effect should take the full width: |
Refactored the ripple effect in the search-history_view.dart file to enhance the visual feedback when interacting with list tiles
|
Added the ripple effect to the complete List tile. Please verify and let me know if there are any other changes. |
| child: Padding( | ||
| padding: const EdgeInsets.only(left: 18, right: 21), | ||
| child: ListTile( | ||
| contentPadding: EdgeInsets.only(left: 18, right: 21), |
There was a problem hiding this comment.
By curiosity, why do set twice the padding?
Also, by consistency, could you use floating values: 18 -> 18.0
There was a problem hiding this comment.
Changed the code to follow consistency.
Also, my bad I was testing something and it slipped right through , will be careful before pushing next time
Refactored the code to use floating values in the search-history_view.dart file
Refactored the code to use floating values in the search-history_view.dart file
|
The fix is done ig. It is ready to merge |
|
It seems that there is still an issue: https://share.waldo.com/294ab6ee641dd9f72e008124c281df26024024?tab=timeline&startTime=39.688 As you can see, the Ripple around the pen (Edit mode) is really small. There should be some padding |
|
Did the fix! |
Impacted file:
search-history_view.dart: added padding to the list tile for proper alignment Resolved the misalignment issue on the search page by adding appropriate padding to the list tile in the search-history_view.dart file. This adjustment ensures that the elements within the list are properly aligned, improving the visual consistency of the search page.
What
search-history_view.dartfile to achieve proper alignment.Screenshot
Fixes bug(s)
Part of