Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve the Nutrition Facts screen #4278

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 7, 2023

Hi everyone,

The nutrition facts screen (the read-only one, in the Product page) has two majors issues:

  • A CupertinoPicker is pretty counterintuitive on Android to change the quantity => A simple TextField is used instead
  • The screen was poorly accessible (each item on the table was selectable, instead of the whole)

As a always a video, of the feature: Nutrition.webm

@codecov-commenter
Copy link

Codecov Report

Merging #4278 (b687853) into develop (505c0d1) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4278      +/-   ##
===========================================
- Coverage    10.87%   10.85%   -0.03%     
===========================================
  Files          285      285              
  Lines        14172    14199      +27     
===========================================
  Hits          1541     1541              
- Misses       12631    12658      +27     
Impacted Files Coverage Δ
...l/knowledge_panels/knowledge_panel_table_card.dart 0.00% <0.00%> (ø)
...ooth_app/lib/pages/product/portion_calculator.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@M123-dev M123-dev linked an issue Jul 16, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

@teolemon
Copy link
Member

Could it possibly be a bottom sheet, with a Copy button

@g123k
Copy link
Collaborator Author

g123k commented Jul 17, 2023

Could it possibly be a bottom sheet, with a Copy button

You mean the sheet or the input text?

@teolemon
Copy link
Member

Sheet, possibly?

@g123k
Copy link
Collaborator Author

g123k commented Jul 17, 2023

Sheet, possibly?

Possible.
But it would be nice to validate #4307 first, as there will be new APIs that would be welcomed here

@M123-dev M123-dev merged commit 829e2a1 into openfoodfacts:develop Jul 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portion calculator amount not in vertical center
4 participants