feat: Robotoff question as a banner or a button #4280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🥫 Product page
Product addition
g123k
added
♿️ accessibility
🤖 Robotoff
and removed
🥫 Product page
Product addition
github-actions
bot
added
🥫 Product page
Product addition
|
I will change the animation with the sun from the onboarding |
Codecov Report
@@ Coverage Diff @@
## develop #4280 +/- ##
===========================================
- Coverage 10.34% 10.31% -0.04%
===========================================
Files 293 294 +1
Lines 14636 14760 +124
===========================================
+ Hits 1514 1522 +8
- Misses 13122 13238 +116
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
You can test this PR on: https://app.waldo.com/applications/app-19d476740ba1bb36/sessions |
|
We have a better animation now: https://rive.app/s/Ti-xrBGssE6gpLxAmwL2vQ/ |
… the screen) or in a button (current implementation) We split the users into two cohorts and we will have some Analytics to understand if one is better than the other. The CongratsWidget is also improved by some animations and accessibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
We don't have an A/B testing solution yet, but I have tried to implement a very naive solution, where each user has now a random int between 0 and 10. In this case, it allows telling that half of the user will see a button and the other half a banner.
Button layout (the animation is fixed with no emoji anymore)
Banner layout (padding is added at the bottom, don't worry)
I have also improved the
CongratsWidgetwith more margins, animations… and obviously some improvements for the accessibility.Videos:
Banner: Banner.webm
Button: Button.webm
Accessibility: Accessibility.webm