Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved country picker #4300

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 13, 2023

Hi everyone,

Here is some improvements for the country picker:

  • There is now a title (I don't use the one provided by the SmoothDialog, because the style doesn't match)
  • There are now dividers between items
  • Running a research will now highlight parts
  • I also fix an issue, where the previous input was persisted when closing/reopening the dialog

A video is better than words: CountryPicker.webm

And a screenshot, just in case: Screenshot_1689257497

This part of #4230 to improve the walkthrough / onboarding.

@g123k g123k added the 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… label Jul 13, 2023
@g123k g123k requested a review from a team as a code owner July 13, 2023 14:16
@g123k g123k self-assigned this Jul 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4300 (644fd96) into develop (296a0d2) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4300      +/-   ##
===========================================
- Coverage    10.82%   10.79%   -0.04%     
===========================================
  Files          288      289       +1     
  Lines        14264    14308      +44     
===========================================
  Hits          1544     1544              
- Misses       12720    12764      +44     
Impacted Files Coverage Δ
...ckages/smooth_app/lib/helpers/keyboard_helper.dart 0.00% <0.00%> (ø)
...oth_app/lib/pages/onboarding/country_selector.dart 0.60% <0.00%> (-0.22%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks @g123k

@M123-dev M123-dev merged commit 6290fa3 into openfoodfacts:develop Jul 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 l10n 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants