Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Some updates to make the app work again on macOS #4309

Merged
merged 3 commits into from
Jul 15, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 14, 2023

The app works well on macOS, but we need to upgrade a few files

@g123k g123k added the MacOS label Jul 14, 2023
@g123k g123k requested a review from a team as a code owner July 14, 2023 18:31
@g123k g123k self-assigned this Jul 14, 2023
@github-actions github-actions bot added the 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… label Jul 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #4309 (e18802e) into develop (1cd22a6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head e18802e differs from pull request most recent head 4a9cce7. Consider uploading reports for the commit 4a9cce7 to get more accurate results

@@             Coverage Diff             @@
##           develop    #4309      +/-   ##
===========================================
- Coverage    10.80%   10.80%   -0.01%     
===========================================
  Files          287      287              
  Lines        14202    14203       +1     
===========================================
  Hits          1534     1534              
- Misses       12668    12669       +1     
Impacted Files Coverage Δ
...ib/pages/preferences/user_preferences_widgets.dart 13.82% <100.00%> (+0.92%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@g123k
Copy link
Collaborator Author

g123k commented Jul 15, 2023

Thank you @monsieurtanuki 🚀

@g123k g123k merged commit 75dd24e into openfoodfacts:develop Jul 15, 2023
6 checks passed
@g123k g123k deleted the mac_update branch July 15, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MacOS 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants