Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sign up request with the country and the language of the user #4329

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 17, 2023

Hi everyone!

Currently, all users are registered with the "world" website, and they receive the newsletter in English.
Before implementing a way to change the language dynamically, we now ensure to send the user's language and country to fit 95% of cases.

@g123k g123k added the Sign-Up label Jul 17, 2023
@g123k g123k requested a review from a team as a code owner July 17, 2023 11:33
@g123k g123k self-assigned this Jul 17, 2023
@github-actions github-actions bot added 👥 User management Account login, signup, signout dependencies labels Jul 17, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4329 (4b5adc8) into develop (5a72a46) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4329      +/-   ##
===========================================
- Coverage    10.54%   10.54%   -0.01%     
===========================================
  Files          290      290              
  Lines        14293    14295       +2     
===========================================
  Hits          1507     1507              
- Misses       12786    12788       +2     
Impacted Files Coverage Δ
...th_app/lib/pages/user_management/sign_up_page.dart 49.78% <0.00%> (-0.44%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

@g123k g123k linked an issue Jul 17, 2023 that may be closed by this pull request
@g123k
Copy link
Collaborator Author

g123k commented Jul 17, 2023

Thanks, @monsieurtanuki for the review.
Let's merge this ASAP, so we don't receive complaints anymore ;)

@g123k g123k merged commit 8051788 into openfoodfacts:develop Jul 17, 2023
7 checks passed
@g123k g123k deleted the signuwith_country_language branch July 17, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The signup doesn't take the country/language
3 participants