Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tweak the location of the floating messages (ex-Snackbar) #4401

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 29, 2023

Hi everyone,

While testing the app in the product edition, I noticed that on some screens, having a bottom message feels better.
Feel free to test with Waldo to tell me if it's better now.

@g123k g123k self-assigned this Jul 29, 2023
@g123k g123k requested a review from a team as a code owner July 29, 2023 20:00
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2023

Codecov Report

Merging #4401 (d7a3470) into develop (05850f3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4401      +/-   ##
===========================================
- Coverage    10.17%   10.17%   -0.01%     
===========================================
  Files          295      295              
  Lines        15045    15048       +3     
===========================================
  Hits          1531     1531              
- Misses       13514    13517       +3     
Files Changed Coverage Δ
...ges/smooth_app/lib/background/background_task.dart 0.00% <0.00%> (ø)
...mooth_app/lib/background/background_task_crop.dart 0.00% <0.00%> (ø)
...th_app/lib/background/background_task_details.dart 0.00% <0.00%> (ø)
.../background/background_task_download_products.dart 0.00% <ø> (ø)
...p/lib/background/background_task_full_refresh.dart 0.00% <0.00%> (ø)
...p/lib/background/background_task_hunger_games.dart 0.00% <ø> (ø)
...ooth_app/lib/background/background_task_image.dart 0.00% <0.00%> (ø)
...th_app/lib/background/background_task_offline.dart 0.00% <0.00%> (ø)
.../lib/background/background_task_refresh_later.dart 0.00% <ø> (ø)
...p/lib/background/background_task_top_barcodes.dart 0.00% <ø> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

You can test this PR on: Android

@teolemon teolemon merged commit e3b4768 into openfoodfacts:develop Jul 31, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants