feat: 4423 - specific "Not connected to internet" displayed error

[monsieurtanuki]

What

• This PR is limited to the product refresh in the product page.
• The current behavior is that the refresh opens a "working..." dialog, and opens a generic "error" dialog if something fails.
• Now, if the refresh fails, we check the connectivity, and if the user is not connected to internet we display a specific message.
• We could even refine the message by ping'ing the server, with a possible "server down" message.
• And later this could be applied to the rest of the server queries (product list refresh for instance). But here we're also in competition with Rethink UI of history refresh not to occlude the view #4425.

Screenshot

Part of

• We should be clearer about the ground cause for errors #4423

Impacted files

• barcode_product_query.dart: removed useless try as already catch'ed
• continuous_scan_model.dart: removed the codeInvalid case that could never happen
• fetched_product.dart: refactored with explicit constructors and additional exception and connectivity fields; removed the codeInvalid case that could never happen
• new_product_page.dart: minor refactoring
• product_dialog_helper.dart: removed the codeInvalid case that could never happen; minor refactoting
• product_list_item_simple.dart: removed the codeInvalid case that could never happen
• product_loader_page.dart: removed useless try as already catch'ed
• product_refresher.dart: added a specific "You're not connected to the internet" error message; refactored using more FetchedProduct; removed useless method
• pubspec.lock: wtf
• pubspec.yaml: added package connectivity_plus
• question_card.dart: refactored using FetchedProduct

[codecov-commenter]

Codecov Report

Merging #4455 (985440a) into develop (1c75f86) will increase coverage by 0.00%.
Report is 2 commits behind head on develop.
The diff coverage is 5.97%.

@@           Coverage Diff            @@
##           develop    #4455   +/-   ##
========================================
  Coverage    10.31%   10.32%           
========================================
  Files          296      296           
  Lines        15311    15328   +17     
========================================
+ Hits          1579     1582    +3     
- Misses       13732    13746   +14     

Files Changed	Coverage Δ
...oth_app/lib/data_models/continuous_scan_model.dart	0.00% <ø> (ø)
...ooth_app/lib/pages/hunger_games/question_card.dart	0.00% <0.00%> (ø)
...ib/pages/product/common/product_dialog_helper.dart	0.00% <0.00%> (ø)
...pages/product/common/product_list_item_simple.dart	0.00% <ø> (ø)
...pp/lib/pages/product/common/product_refresher.dart	0.00% <0.00%> (-1.21%)	⬇️
...smooth_app/lib/pages/product/new_product_page.dart	0.46% <0.00%> (ø)
...oth_app/lib/pages/product/product_loader_page.dart	1.33% <0.00%> (-0.06%)	⬇️
...es/smooth_app/lib/query/barcode_product_query.dart	0.00% <0.00%> (ø)
...es/smooth_app/lib/data_models/fetched_product.dart	33.33% <33.33%> (+33.33%)	⬆️
packages/smooth_app/lib/main.dart	13.60% <100.00%> (+0.69%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

You can test this PR on: Android

[monsieurtanuki]

Additional possibility: "server down".

Let me sum up what may happen when we refresh a product:

• we find the product => no error dialog
• we don't find the product => "No product found" dialog
• there was an exception
  • if there was no connectivity => "You're not connected to internet!" dialog
  • if we cannot ping the server => "Server down!"
  • final possibility => "Server error ($exception)"

[teolemon]

Analyzing smooth-app...

info • Sort directive sections alphabetically • packages/smooth_app/lib/pages/preferences/user_preferences_dev_mode.dart:10:1 • directives_ordering

[monsieurtanuki]

Analyzing smooth-app...

info • Sort directive sections alphabetically • packages/smooth_app/lib/pages/preferences/user_preferences_dev_mode.dart:10:1 • directives_ordering

@teolemon Done.

[g123k]

Additional possibility: "server down".

Let me sum up what may happen when we refresh a product:

• we find the product => no error dialog

• we don't find the product => "No product found" dialog

• there was an exception

  • if there was no connectivity => "You're not connected to internet!" dialog
  • if we cannot ping the server => "Server down!"
  • final possibility => "Server error ($exception)"

I think that would be way better that way.
Just by curiosity: why didn't you translate the new strings?

[monsieurtanuki]

I think that would be way better that way.

@g123k That's the way it is coded in the latest version of the PR, so feel free to approve.

Just by curiosity: why didn't you translate the new strings?

If I were in a world where I had only ideas that were immediately approved, I would directly add the translations.
I currently don't live in that world, so instead of polluting the translations with labels that will never be used or giving me useless additional work, I prefer to put hard-coded strings, and if the code is approved I localize the strings.
This is not like we all agreed beforehand on the different cases and their related labels, here it's a bit more experimental.

[g123k]

I think that would be way better that way.

@g123k That's the way it is coded in the latest version of the PR, so feel free to approve.

Just by curiosity: why didn't you translate the new strings?

If I were in a world where I had only ideas that were immediately approved, I would directly add the translations. I currently don't live in that world, so instead of polluting the translations with labels that will never be used or giving me useless additional work, I prefer to put hard-coded strings, and if the code is approved I localize the strings. This is not like we all agreed beforehand on the different cases and their related labels, here it's a bit more experimental.

Ok, so I approve your PR, so it's OK to translate ;)

[monsieurtanuki]

Thank you @g123k for your review!

Probably related to #4549.
In general, we should test the connection and ping the server each time the server is called and the request failed.