Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Better support errors on the forgot password page #4493

Merged
merged 3 commits into from
Aug 9, 2023
Merged

feat: Better support errors on the forgot password page #4493

merged 3 commits into from
Aug 9, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 9, 2023

Hi everyone,

Here is a fix for the forgot password page, with:

  • A correct message if the email/username is invalid
  • If there is an error on the server

⚠️ However, for now, there is still an issue (and I don't know why) because the server doesn't return the correct message.

@g123k g123k added the 👥 User management Account login, signup, signout label Aug 9, 2023
@g123k g123k self-assigned this Aug 9, 2023
@g123k g123k requested a review from a team as a code owner August 9, 2023 06:46
@g123k g123k linked an issue Aug 9, 2023 that may be closed by this pull request
Reset the password is marked as failed… but I've received the email #4470
Closed
@g123k g123k marked this pull request as draft August 9, 2023 08:52
@g123k
Copy link
Collaborator Author

g123k commented Aug 9, 2023

Please DO NOT merge this PR.
We need a new version of the Dart package, as there is an important issue: openfoodfacts/openfoodfacts-dart#779

@g123k g123k marked this pull request as ready for review August 9, 2023 14:53
@teolemon teolemon merged commit c9fb89a into openfoodfacts:develop Aug 9, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@g123k g123k

Labels
dependencies 🌐 l10n 🔐 Password reset 👥 User management Account login, signup, signout
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reset the password is marked as failed… but I've received the email
2 participants
@g123k @teolemon