feat: 4554 - new links in FAQ #4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `app_en.arb`: added labels for the 9 new items * `app_fr.arb`: added labels for 4 new items * `user_preferences_faq.dart`: added 9 items; fixed 2 items * `product_query.dart`: new `replaceSubdomain` method
Codecov Report
@@ Coverage Diff @@
## develop #4572 +/- ##
===========================================
- Coverage 10.34% 10.30% -0.05%
===========================================
Files 296 296
Lines 15340 15403 +63
===========================================
Hits 1587 1587
- Misses 13753 13816 +63
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Ok, we need some inclusivity work on the cosmetic icon :-) How about we do simple, and use the official icons for the projects ?
|
Impacted files: * `RVB_ICON_BLACK_BG_OBF.svg`: dark version of Beauty app icon * `RVB_ICON_BLACK_BG_OPF.svg`: dark version of Product app icon * `RVB_ICON_BLACK_BG_OPFF.svg`: dark version of Pet Food app icon * `RVB_ICON_WHITE_BG_OBF.svg`: light version of Beauty app icon * `RVB_ICON_WHITE_BG_OPF.svg`: light version of Product app icon * `RVB_ICON_WHITE_BG_OPFF.svg`: light version of Pet Food app icon * `user_preferences_faq.dart`: new icons for app install, dark and light
|
@teolemon App icons are small, aren't they?
|
|
I don't know if we could trim them, and how relevant that would be if we want to reuse them for more serious things at a later time. Eg icon of a flavor |
|
@teolemon We can cheat a little, and display svg bigger than icons All centered in 48x48, svg width 48, icon standard size 24:
All centered in 48x48, svg width 48, icon size 36:
|
|
Nice for the nutriscore size 👌 |
Impacted file: * `user_preferences_faq.dart`: all icons are now centered on a 48x48 square, the real icons have the standard size, and the svg icons have a width of 48
|
@teolemon I've just pushed the "All centered in 48x48, svg width 48, icon standard size 24" version. |
Impacted files: * `app_en.arb`: added labels for the new 5 items * `user_preferences_connect.dart`: added 5 items * `user_preferences_faq.dart`: minor refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
Fixes bug(s)
Impacted files
app_en.arb: added labels for the 9 new itemsapp_fr.arb: added labels for 4 new itemsuser_preferences_faq.dart: added 9 items; fixed 2 itemsproduct_query.dart: newreplaceSubdomainmethod