Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use Open Sans as the default font #4676

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Sep 30, 2023

Hi everyone,

Previously, the app used the Plus Jakarta Sans font, but it didn't work well in some languages.
As part of the redesign, we will now switch to Open Sans, which seems to be OK with many languages (Latin, Greek, Cyrillic, Hebrew…)

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2023

Codecov Report

Merging #4676 (7c6b871) into develop (c31e458) will decrease coverage by 0.01%.
Report is 9 commits behind head on develop.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #4676      +/-   ##
==========================================
- Coverage     9.91%   9.90%   -0.01%     
==========================================
  Files          310     310              
  Lines        15792   15807      +15     
==========================================
  Hits          1566    1566              
- Misses       14226   14241      +15     
Files Coverage Δ
packages/smooth_app/lib/themes/smooth_theme.dart 76.08% <ø> (ø)

... and 35 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise okay👍🏻

@teolemon teolemon merged commit 9a1ba90 into openfoodfacts:develop Oct 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants