fix: Truncated button text #4240 #4677
Conversation
|
@monsieurtanuki should I update branch? |
There was a problem hiding this comment.
Thank you @malik-vishu for your PR.
Please have a look at my comments.
The general idea is that you should have a minimal impact on the app and just focus on the issue - e.g. you should not dismiss or change a generic parameter just because it's helpful in that particular case.
| @@ -74,7 +74,7 @@ class SmoothDraggableBottomSheetState | |||
| child: Material( | |||
| type: MaterialType.transparency, | |||
| child: ClipRRect( | |||
| borderRadius: widget.borderRadius, | |||
| // borderRadius: widget.borderRadius, | |||
There was a problem hiding this comment.
Please put it back. If it's a parameter we introduced, let's assume it is useful.
There was a problem hiding this comment.
type 'BorderRadius?' can't be assigned to the parameter type 'BorderRadiusGeometry'
What to do with this error then?
There was a problem hiding this comment.
In that case, as @g123k recently switched to flutter 3.13 (from 3.10), I guess it would make sense to "Update branch". That would probably include the fix to this error.
For the record: when there's an error, the trick is not to comment it, especially if your code gets reviewed 😉
packages/smooth_app/lib/generic_lib/buttons/smooth_large_button_with_icon.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/generic_lib/buttons/smooth_large_button_with_icon.dart
Show resolved
Hide resolved
Given that the PR is located in very specific files that are not really connected to major features of the app and with no collision with other PRs, perhaps it's slightly better not to (additional automatic processes and emails and so on). But if you feel like doing it, just do it. |
|
@monsieurtanuki Now check. |
|
@monsieurtanuki Please check |
Codecov Report
@@ Coverage Diff @@
## develop #4677 +/- ##
=======================================
Coverage 9.91% 9.91%
=======================================
Files 310 310
Lines 15792 15792
=======================================
Hits 1566 1566
Misses 14226 14226
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@monsieurtanuki Thank you for the chance and direction. |
Truncated button text
Text truncation problem resolved on Packaging Components screen
Screenshot
Fixes bug(s)
Issue
smooth_draggable_bottom_sheet.dartFiles changed
smooth_draggable_bottom_sheet.dartedit_new_packagings.dartproduct_cards_helper.dart