chore: upgrade to off-dart 3.0.0 #4686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `background_task.dart`: minor refactoring * `background_task_crop.dart`: added the `UriProductHelper` parameter * `background_task_details.dart`: added the `UriProductHelper` parameter * `background_task_download_products.dart`: added the `UriProductHelper` parameter * `background_task_image.dart`: added the `UriProductHelper` parameter * `background_task_top_barcodes.dart`: added the `UriProductHelper` parameter * `background_task_unselect.dart`: added the `UriProductHelper` parameter * `forgot_password_page.dart`: added the `UriProductHelper` parameter * `ocr_ingredients_helper.dart`: added the `UriProductHelper` parameter * `ocr_packaging_helper.dart`: added the `UriProductHelper` parameter * `onboarding_data_product.dart`: added the `UriProductHelper` parameter * `ordered_nutrients_cache.dart`: added the `UriProductHelper` parameter * `paged_product_query.dart`: added the `UriProductHelper` parameter * `product_cards_helper.dart`: now using an off-dart method * `product_image_server_button.dart`: added the `UriProductHelper` parameter * `product_list_import_export.dart`: added the `UriProductHelper` parameter * `product_list_page.dart`: added the `UriProductHelper` parameter * `product_query.dart`: added a static `UriProductHelper` that more or less replaces the `QueryType`; minor refactoring * `product_refresher.dart`: added the `UriProductHelper` parameter * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded off-dart to 3.0.0 * `random_questions_query.dart`: `countries` instead of `country` * `sign_up_page.dart`: added the `UriProductHelper` parameter * `temp_product_list_share_helper.dart`: now using a `UriProductHelper` * `user_management_provider.dart`: added the `UriProductHelper` parameter * `user_preferences_account.dart`: added the `UriProductHelper` parameter * `user_preferences_dev_debug_info.dart`: minor refactoring * `user_preferences_dev_mode.dart`: minor refactoring
github-actions
bot
added
🥫 Product page
👥 User management
Codecov Report
@@ Coverage Diff @@
## develop #4686 +/- ##
==========================================
- Coverage 9.91% 9.90% -0.02%
==========================================
Files 310 310
Lines 15792 15816 +24
==========================================
Hits 1566 1566
- Misses 14226 14250 +24
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you @g123k for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Impacted files
background_task.dart: minor refactoringbackground_task_crop.dart: added theUriProductHelperparameterbackground_task_details.dart: added theUriProductHelperparameterbackground_task_download_products.dart: added theUriProductHelperparameterbackground_task_image.dart: added theUriProductHelperparameterbackground_task_top_barcodes.dart: added theUriProductHelperparameterbackground_task_unselect.dart: added theUriProductHelperparameterforgot_password_page.dart: added theUriProductHelperparameterocr_ingredients_helper.dart: added theUriProductHelperparameterocr_packaging_helper.dart: added theUriProductHelperparameteronboarding_data_product.dart: added theUriProductHelperparameterordered_nutrients_cache.dart: added theUriProductHelperparameterpaged_product_query.dart: added theUriProductHelperparameterproduct_cards_helper.dart: now using an off-dart methodproduct_image_server_button.dart: added theUriProductHelperparameterproduct_list_import_export.dart: added theUriProductHelperparameterproduct_list_page.dart: added theUriProductHelperparameterproduct_query.dart: added a staticUriProductHelperthat more or less replaces theQueryType; minor refactoringproduct_refresher.dart: added theUriProductHelperparameterpubspec.lock: wtfpubspec.yaml: upgraded off-dart to 3.0.0random_questions_query.dart:countriesinstead ofcountrysign_up_page.dart: added theUriProductHelperparametertemp_product_list_share_helper.dart: now using aUriProductHelperuser_management_provider.dart: added theUriProductHelperparameteruser_preferences_account.dart: added theUriProductHelperparameteruser_preferences_dev_debug_info.dart: minor refactoringuser_preferences_dev_mode.dart: minor refactoring