fix: Exception when product brands are null #4699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4699 +/- ##
=======================================
Coverage 9.90% 9.90%
=======================================
Files 310 310
Lines 15815 15808 -7
=======================================
Hits 1566 1566
+ Misses 14249 14242 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@WildOrangutan Please fix and attach issues #4692 #4693 #4694. |
|
Hm, I see some issues are related to my fix. Ok, will refactor and also fix those. |
WildOrangutan
force-pushed
the
peter/fix/product-brands-null
branch
from
fefaac7
to
179d581
Compare
github-actions
bot
added
✏️ Editing - Nutrition input
✏️ Editing - Packaging input
WildOrangutan
commented
Oct 5, 2023
WildOrangutan
force-pushed
the
peter/fix/product-brands-null
branch
3 times, most recently
from
9b68bda
to
04e17b0
Compare
This was
linked to
issues
Oct 6, 2023
There was a problem hiding this comment.
Thank you @WildOrangutan for your PR!
We'll even be better off with a systematic Widget getProductTitle method.
Please have a look at my comments and tell me what you think.
packages/smooth_app/lib/pages/product/add_basic_details_page.dart
Outdated
Show resolved
Hide resolved
| @@ -11,14 +11,22 @@ import 'package:smooth_app/helpers/image_field_extension.dart'; | |||
| import 'package:smooth_app/helpers/ui_helpers.dart'; | |||
| import 'package:smooth_app/query/product_query.dart'; | |||
|
|
|||
| String getProductNameAndBrands( | |||
There was a problem hiding this comment.
Suggested change
| String getProductNameAndBrands( | |
| Widget getProductTitle( | |
| final Product product, | |
| final AppLocalizations appLocalizations, | |
| ) => Text( | |
| getProductNameAndBrands(upToDateProduct, appLocalizations), | |
| overflow: TextOverflow.ellipsis, | |
| maxLines: 1, | |
| ); | |
| String getProductNameAndBrands( |
There was a problem hiding this comment.
Named it buildProductTitle, so it's hopefully gives a hint, that it returns different type, compared to getProductName below.
WildOrangutan
force-pushed
the
peter/fix/product-brands-null
branch
from
04e17b0
to
3565a4d
Compare
monsieurtanuki
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixing some null exception, that I randomly found while working on other issues, due to this bang operator:
widget.product.brands!Fixes bug(s)
Fixes #4692, #4693, #4694