Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump connectivity_plus from 4.0.2 to 5.0.1 in /packages/smooth_app #4776

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 10, 2023

Bumps connectivity_plus from 4.0.2 to 5.0.1.

Commits
  • 03d0523 chore(release): prepare for release (#2266)
  • e489d4a fix(connectivity_plus): Fix CHANGELOG to not mention Kotlin requirement (#2246)
  • a89dc83 chore(release): prepare for release (#2238)
  • 01df65c fix(connectivity_plus): Revert bump compileSDK to 34 (#2229)
  • 2f1e3a4 chore(connectivity_plus): Update compileSDK to 34 for example (#2207)
  • f73bf44 chore(all): Update Android compileSDK to 34 (#2051)
  • 11c293d chore(deps): bump com.android.tools.build:gradle from 8.1.1 to 8.1.2 in /pack...
  • cf7d93f fix(connectivity_plus)!: Bump min iOS to 12 to support XCode 15 (#2169)
  • d219331 chore(deps): bump com.android.tools.build:gradle from 8.1.1 to 8.1.2 in /pack...
  • b7e16e5 chore(connectivity_plus): Change group name (#2110)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [connectivity_plus](https://github.com/fluttercommunity/plus_plugins/tree/main/packages/connectivity_plus) from 4.0.2 to 5.0.1.
- [Release notes](https://github.com/fluttercommunity/plus_plugins/releases)
- [Commits](https://github.com/fluttercommunity/plus_plugins/commits/connectivity_plus-v5.0.1/packages/connectivity_plus)

---
updated-dependencies:
- dependency-name: connectivity_plus
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner November 10, 2023 17:27
@codecov-commenter
Copy link

Codecov Report

Merging #4776 (a23de00) into develop (ae64157) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #4776   +/-   ##
=======================================
  Coverage     9.89%   9.89%           
=======================================
  Files          312     312           
  Lines        15809   15809           
=======================================
  Hits          1565    1565           
  Misses       14244   14244           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@monsieurtanuki
Copy link
Contributor

Looks interesting

BREAKING FIX(connectivity_plus): Bump min iOS to 12 to not crash after builds with Xcode 15

The thing is that according to our Podfile we're still using iOS 11 (platform :ios, '11.0').
But I don't understand that much about iOS in general and Podfile in particular.
@g123k Your views on the subject?

@g123k
Copy link
Collaborator

g123k commented Nov 13, 2023

Yes, it's OK to move to iOS 12, as it's now the minimum required for Xcode:

The Xcode 15 release supports on-device debugging in iOS 12 and later, tvOS 12 and later, and watchOS 4 and later.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should explicitly upgrade the ios version in our Podfile too.
Let's keep that in mind in case we face a problem on ios.

@monsieurtanuki monsieurtanuki merged commit 1bd71a6 into develop Nov 13, 2023
8 checks passed
@monsieurtanuki monsieurtanuki deleted the dependabot/pub/packages/smooth_app/connectivity_plus-5.0.1 branch November 13, 2023 08:17
@g123k
Copy link
Collaborator

g123k commented Nov 13, 2023

Not sure if we should explicitly upgrade the ios version in our Podfile too. Let's keep that in mind in case we face a problem on ios.

For the Podfile, the build may fail if we use dependencies with iOS 12 as a requirement.
In all other cases, there is no impact

@monsieurtanuki
Copy link
Contributor

For the Podfile, the build may fail if we use dependencies with iOS 12 as a requirement.

That's exactly the case of the new version of connectivity_plus, AFAIK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants