feat: 4996 - reordering product languages #5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New file: * `language_priority.dart`: Helper around the language priority. Impacted files: * `add_basic_details_page.dart`: minor refactoring * `dao_string_list.dart`: now storing the latest languages used locally in the app * `edit_ocr_page.dart`: minor refactoring * `language_selector.dart`: now showing app and product languages as first languages * `multilingual_helper.dart`: minor refactoring
M123-dev
approved these changes
Feb 4, 2024
|
Thank you @M123-dev for your review! @alexgarel I hope that will solve most of your "Italian" problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Now we sort the product languages so that the more interesting languages are displayed first in the language selector:
Screenshot
Spanish is close to the top as it's the app language:
Fixes bug(s)
Impacted files
New file:
language_priority.dart: Helper around the language priority.Impacted files:
add_basic_details_page.dart: minor refactoringdao_string_list.dart: now storing the latest languages used locally in the appedit_ocr_page.dart: minor refactoringlanguage_selector.dart: now showing app and product languages as first languagesmultilingual_helper.dart: minor refactoring