Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Invoke the main Navigator when GoRouter is empty #5085

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Feb 24, 2024

Hi everyone,

This is a fix for #5081, where we can't exit the app.

@g123k g123k requested a review from a team as a code owner February 24, 2024 12:40
@g123k g123k self-assigned this Feb 24, 2024
@g123k g123k linked an issue Feb 24, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 9.51%. Comparing base (4d9c7fc) to head (09b57e6).
Report is 35 commits behind head on develop.

Files Patch % Lines
...ackages/smooth_app/lib/widgets/will_pop_scope.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5085      +/-   ##
==========================================
- Coverage     9.54%   9.51%   -0.04%     
==========================================
  Files          325     327       +2     
  Lines        16411   16498      +87     
==========================================
+ Hits          1567    1569       +2     
- Misses       14844   14929      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 😃👍🏼

@teolemon teolemon merged commit e3aea8c into openfoodfacts:develop Feb 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to close the app ?
3 participants