Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5 new icons: chicken / fish / milk / soda happy / soda unhappy #5268

Merged
merged 3 commits into from
May 19, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented May 18, 2024

Hi everyone,

Here are 5 new icons required by the Nutri-Score V2 guide:
Screenshot 2024-05-18 at 11 22 55

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.58%. Comparing base (4d9c7fc) to head (1e498e7).
Report is 123 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5268      +/-   ##
==========================================
- Coverage     9.54%   8.58%   -0.97%     
==========================================
  Files          325     330       +5     
  Lines        16411   16829     +418     
==========================================
- Hits          1567    1444     -123     
- Misses       14844   15385     +541     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Why do we need a happy soda btw ?

@g123k
Copy link
Collaborator Author

g123k commented May 18, 2024

Ok. Why do we need a happy soda btw ?

It's not used for the the Nutriscore guide, but it can be later.
The idea is that during build phase, unused icons are removed.
So the "just in case" paradigm is OK

@teolemon
Copy link
Member

LGTM

@g123k
Copy link
Collaborator Author

g123k commented May 19, 2024

Oops, I forgot the salt icon

@teolemon
Copy link
Member

Approved @g123k

@g123k g123k merged commit 74cf6c6 into openfoodfacts:develop May 19, 2024
6 checks passed
@g123k
Copy link
Collaborator Author

g123k commented May 19, 2024

Thanks, I need this PR for the guide.
So ,merging it.

@g123k g123k deleted the icon_180524 branch May 19, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants