Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce the daily intake visualization already in the code as a Knowledge panel #527

Open
1 task
Tracked by #523 ...
teolemon opened this issue Aug 23, 2021 · 10 comments
Open
1 task
Tracked by #523 ...
Assignees
Labels
✨ enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed P3 🥫 Product page

Comments

@teolemon
Copy link
Member

teolemon commented Aug 23, 2021

What

  • Reintroduce the daily intake visualization already in the code as a Knowledge panel on the product page

Code pointers

Screenshot

  • The feature as it appeared in Quick view (note: we would move it to the full Product page)

Part of

@M123-dev
Copy link
Member

@teolemon

File not found

Either this file doesn’t exist or you don’t have permission to view it. Ask the file owner to verify the link and/or update permissions.

@teolemon
Copy link
Member Author

teolemon commented Jan 7, 2022

pierre@MacBook-Pro-de-Pierre smooth-app % git rev-list -n 1 HEAD -- packages/smooth_app/lib/cards/data_cards/smooth_intake_recommendation_card.dart
194da75

@teolemon
Copy link
Member Author

teolemon commented Jan 7, 2022

@M123-dev I've added the screenshot, and I've found the removal commit

@jasmeet0817
Copy link
Contributor

We want this on the Scan page ? I don't think we have space there :(

@teolemon
Copy link
Member Author

No, I was thinking of moving it on the Product Page, at the bottom

@teolemon teolemon added the help wanted Extra attention is needed label Jan 22, 2022
@teolemon
Copy link
Member Author

teolemon commented Feb 6, 2022

  • Getting rid of the dark mode hardcode
  • Putting it as disabled by default (behind a flag), I think we can enhance usability

Health tracking

@teolemon teolemon added this to the V2 milestone Mar 31, 2022
@teolemon teolemon added the P4 label May 20, 2022
@teolemon teolemon added good first issue Good for newcomers P3 and removed P4 labels Oct 8, 2022
@M123-dev M123-dev removed this from the V2 milestone Nov 6, 2022
@Adiii1436
Copy link
Contributor

Adiii1436 commented Feb 15, 2023

This seems interesting. @teolemon @M123-dev I want to work on this issue. Please assign this to me.

@M123-dev
Copy link
Member

The first step would be to re-add it, but behind a switch in the dev mode. To first test

@Adiii1436
Copy link
Contributor

@M123-dev At 194da5 deleted files like smooth_quantity_selector_card.dart import missing files which is not present at the time of removal. That implies it was removed before it.

@M123-dev
Copy link
Member

Which imports are missing, maybe I can help with this

@teolemon teolemon added the ✨ enhancement New feature or request label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed P3 🥫 Product page
Projects
Status: To do
Status: 📋 Todo (ready 2 dev)
Development

No branches or pull requests

4 participants