Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client-side attribute matching might be inconsistent with the server #579

Closed
Tracked by #1284 ...
slava-sh opened this issue Sep 17, 2021 · 1 comment
Closed
Tracked by #1284 ...

Comments

@slava-sh
Copy link
Member

slava-sh commented Sep 17, 2021

What

Looking at the server code for the nutrient levels, $match is 20 and the icon is nutrient-level-$nid-medium.svg when $value is $high:

			elsif ($value <= $high) {
				$match = 20 + 60 * ($high - $value) / ($high - $low);
				$attribute_ref->{icon_url} = "$static_subdomain/images/attributes/nutrient-level-$nid-medium.svg";
			}

However, on the client, match == 20 is mapped to lowestMatchResult.

This seems to be inconsistent.

Part of

@teolemon
Copy link
Member

teolemon commented Sep 1, 2022

The scoring system was rewritten, so I believe we can close @slava-sh @stephanegigandet

@teolemon teolemon closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants