Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary search widget rebuilds #844

Open
Tracked by #991
M123-dev opened this issue Jan 4, 2022 · 0 comments
Open
Tracked by #991

Unnecessary search widget rebuilds #844

M123-dev opened this issue Jan 4, 2022 · 0 comments
Milestone

Comments

@M123-dev
Copy link
Member

M123-dev commented Jan 4, 2022

What

To Reproduce

  1. Add print('PRINT build search widget autofocus=${widget.autofocus}'); on the first line of the SearchField build method (not SearchPage, both are in the same file) (I always put print in caps at the start so that I can search the logs for my print messages)

  2. When then searching something you can see a lot of these messages, some with autofocus=true and a lot with autofocus=false

  3. The autofocus=false even get printen further when navigating to the product page

  4. The autofcous=false builds are from the search bar on the welcome card in the carussel, which is not supposed to be rebuilt here

Expected behavior

It should not rebuild.

Part of

@M123-dev M123-dev added 🐛 bug Something isn't working performance labels Jan 4, 2022
@teolemon teolemon added this to the V1.1 milestone Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Todo (ready 2 dev)
Development

No branches or pull requests

2 participants