Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we still use jquery-ui? Remove it if needed. #10380

Open
jibees opened this issue Feb 6, 2023 · 0 comments
Open

Do we still use jquery-ui? Remove it if needed. #10380

jibees opened this issue Feb 6, 2023 · 0 comments

Comments

@jibees
Copy link
Contributor

jibees commented Feb 6, 2023

Files imported:

@import '~jquery-ui/themes/base/core';
@import '~jquery-ui/themes/base/button';
@import '~jquery-ui/themes/base/resizable';
@import '~jquery-ui/themes/base/dialog';

All classes defined in those files starts with ui-

I searched for ui- in all haml files:

➜  openfoodnetwork git:(master) grep "ui-" -inr --include \*.haml
./app/views/registration/steps/_location_map.html.haml:9:      %ui-gmap-google-map{ center: "map.center", zoom: "map.zoom"}
./app/views/registration/steps/_location_map.html.haml:10:        %ui-gmap-marker{idKey: 1, coords: "latLong", options: '{ draggable: true}'}
./app/views/shared/_map.html.haml:11:      %ui-gmap-google-map{options: "map.additional_options", center: "map.center", zoom: "map.zoom",
./app/views/shared/_map.html.haml:14:        %ui-gmap-markers{models: "OfnMap.enterprises", fit: "true", 

All occurrences starts with ui-gmap which is not defined in any of those previous files.

So, the question is: do we still use jquery-ui?

Originally posted by @jibees in #10370 (comment)

@jibees jibees changed the title Do we still use jquery-ui. Remove it. Do we still use jquery-ui? Remove it if needed. Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: All the things
Development

No branches or pull requests

1 participant