Release v4.2.34

[dacook]

Preparation on Thursday

• Merge pull requests in the Ready To Go column
• Include translations: tx pull --force
• Draft new release. Look at previous releases for inspiration.
• Notify #instance-managers of user-facing changes.

Testing

• Find build of the release commit and copy it below.
• Move this issue to Test Ready.
• Notify @testers in #testing.
• Test build: https://semaphoreci.com/openfoodfoundation/openfoodnetwork-2/branches/master/builds/4166

Finish on Tuesday

• Publish and notify #global-community (this is automatically posted with a plugin)
• Deploy the new release to all managed instances.
  Command line instructions

  cd ofn-install
  git pull
  ansible-playbook --limit all-prod --extra-vars "git_version=vx.y.z" playbooks/deploy.yml
  

• Notify #instance-managers:

  @instance_managers The new release has been deployed.

• Nudge next release manager

The full process is described at https://github.com/openfoodfoundation/openfoodnetwork/wiki/Releasing.

[drummer83]

Hi @dacook,
I have tested this release. Notes are here: https://docs.google.com/document/d/1YoVmHC5Q__QhTUlA-1bUlbthe8ZggLFZRLNJJ_ALZvU/edit?usp=sharing

Everything seems fine, unless it looks like #10375 didn't cover all cases. The situation has improved a lot though:
Before (release v4.2.33):

After (release v4.2.34):

Up to you or @openfoodfoundation/train-drivers-product-owners to decide if we want to move forward and risk having unhappy users who were hoping for a final solution or if we postpone or change the release.

Adding feedback needed.
Thanks!

[filipefurtad0]

Hey @drummer83 ,

Thanks for testing this release 💪

I'm not sure the second picture relates to the bug #10363, introduced by pagination. I think it is possible to have missing information in the BOM page (under some obscure circumstances, I must admin 😅 )

I would say we need more information on it, to make a decision on blocking a release. A quick test could be:

• staging a release, previous to the introduction of pagination -> pagination was introduced in v4.2.32, so I guess staging v4.2.31 would be appropriate
• reopening that page and verifying whether the missing entries are still there

What do you think?

If these missing entries are still there, then I suspect it could relate to:

• orders placed for distributors which were removed from an order cycle (after the placement of that order)
• permission changes, over products or over right to be added to order cycles

[RachL]

If I understand everything, we have a release that improves the situation and does not introduce further regressions: let's not postpone it and deploy it on Tuesday now that most of the release process has been done 👍

Even if we see after the test mentioned by Filipe that there are still cases that can be improved, I still think this release can follow the normal process.

[drummer83]

Yes, ok. Let's move ahead.

I can confirm that the missing data can be observed in v 4.2.31 (before pagination) as well.

Empty producer field:

• line items of suppliers which the distributor has no permission for anymore --> makes kind of sense maybe?
• --> providing permission to add to order cycle brings the information back
• --> a note like 'permission has been removed' instead of empty field would be more clear
• --> wishlist #402

Empty order cycle field:

• all line items of an order cycle which ended more than ~90 days ago --> makes no sense? (independent on permissions)
• --> [BOM] Empty fields for 'order cycle' if order cycle closed more than ~90 days ago #10421

[dacook]

Thanks everyone for checking on this. Sounds like we're good to go, so I've ticked the 'test build' checkbox and will deploy on Tuesday morning (AU).

[dacook]

🚀 Released and deployed