Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vouchers] Include unfixed amounts and percentage rates #10727

Closed
lin-d-hop opened this issue Apr 20, 2023 · 0 comments · Fixed by #10821
Closed

[Vouchers] Include unfixed amounts and percentage rates #10727

lin-d-hop opened this issue Apr 20, 2023 · 0 comments · Fixed by #10821
Assignees
Labels
funded feature priority We focus on this issue right now

Comments

@lin-d-hop
Copy link
Contributor

lin-d-hop commented Apr 20, 2023

Description

Extending the first bare minimum iteration of vouchers this next stage will expand the functionality to include:

  • Both Percentage and Flat Amount for Voucher Type
  • The Amount can be set to anything. For percentage this is between 0 and 100 as a double. For Flat Amount this is a non-negative double.
    Screenshot from 2023-04-20 07-32-19
    Screenshot from designs here

The rate will be reflected in the list page and will be calculated accurately at checkout.

Acceptance Criteria & Tests

  1. Create voucher codes in the backoffice - using a range of percentages to test edge cases (0, 100 etc) and amounts (more than order total, exactly order total etc)
  2. Apply to a checkout flow and see the discount applied
  3. If the order total goes below zero when the code is applied it should stay at zero
  4. Disregard (at this stage) any case that additional negative fees apply to the order
  5. Voucher codes should be able to be used unlimited number of times
  6. Voucher codes should apply to any shoppers
  7. Voucher codes should not apply in enterprises that have not enabled them. If the enterprise has enabled no voucher code the voucher code box should not be visible at checkout
  8. If the voucher code covers the cost of the whole order, just display the full range of payment methods, no clever logic at this stage.
  9. Translations as standard
  10. Unit tests as standard
@rioug rioug self-assigned this Apr 20, 2023
@sigmundpetersen sigmundpetersen added the priority We focus on this issue right now label Jul 12, 2023
@drummer83 drummer83 added pr-staged-au staging.openfoodnetwork.org.au and removed pr-staged-au staging.openfoodnetwork.org.au labels Jul 27, 2023
@sigmundpetersen sigmundpetersen linked a pull request Aug 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
funded feature priority We focus on this issue right now
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants