Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.4 - No masters #11110

Closed
10 of 12 tasks
dacook opened this issue Jun 23, 2023 · 12 comments
Closed
10 of 12 tasks

Release v4.4 - No masters #11110

dacook opened this issue Jun 23, 2023 · 12 comments
Assignees

Comments

@dacook
Copy link
Member

dacook commented Jun 23, 2023

Preparation on Thursday

Testing

Finish on Tuesday

  • Publish and notify #global-community (this is automatically posted with a plugin)
  • Deploy the new release to all managed instances.
    Command line instructions
    cd ofn-install
    git pull
    ansible-playbook --limit all-prod --extra-vars "git_version=vx.y.z" playbooks/deploy.yml
    
  • Notify #instance-managers:

    @instance_managers The new release has been deployed.

  • Nudge next release manager

The full process is described at https://github.com/openfoodfoundation/openfoodnetwork/wiki/Releasing.

@dacook dacook self-assigned this Jun 23, 2023
@sigmundpetersen sigmundpetersen changed the title v4.4.0 - No masters v4.4 - No masters Jun 23, 2023
@sigmundpetersen sigmundpetersen changed the title v4.4 - No masters Release v4.4 - No masters Jun 23, 2023
@drummer83 drummer83 added pr-staged-uk staging.openfoodnetwork.org.uk pr-staged-au staging.openfoodnetwork.org.au pr-staged-fr staging.coopcircuits.fr and removed pr-staged-uk staging.openfoodnetwork.org.uk pr-staged-au staging.openfoodnetwork.org.au pr-staged-fr staging.coopcircuits.fr labels Jun 23, 2023
@drummer83
Copy link
Contributor

Hi @dacook,

Thanks for preparing the release! I have tested this on all three staging servers and did a bit more than our standard release test, e.g. create variants, run some reports, due to the big change around master variants. Yes - I am nervous. 😉

I couldn't find any problems. Testing notes are here: https://docs.google.com/document/d/1IXhyqPA2KSmTRZ1FK0BChvS426VLJTrMiuMUd0Sk208/edit

There is just one new (handled) Bugsnag when an order cycle closes during checkout. I didn't see any issue in the shopfront around this, but I thought I'd mention it here - just in case.
https://app.bugsnag.com/yaycode/openfoodnetwork-aus/errors/6493c3f52dc0cc0007a36bac?filters[event.since]=30d&filters[error.status]=open&filters[app.release_stage]=staging

Moving to Ready to go! 🤞

@drummer83 drummer83 self-assigned this Jun 23, 2023
@jibees
Copy link
Contributor

jibees commented Jun 23, 2023

Yes - I am nervous. 😉

This is probably a good news here. Thanks for the deep testing @drummer83 !!

@filipefurtad0
Copy link
Contributor

Awesome, great to hear @drummer83,

There is just one new (handled) Bugsnag when an order cycle closes during checkout.

This was introduced a while ago - Jan 31, 2022, to trigger a Bugsnag notification, each time an order cycle closes, when a customer in on the process of completing an order. So, nothing to worry about here - just our monitoring working.

@drummer83 drummer83 added pr-staged-uk staging.openfoodnetwork.org.uk and removed pr-staged-uk staging.openfoodnetwork.org.uk labels Jun 23, 2023
@mkllnk
Copy link
Member

mkllnk commented Jun 26, 2023

Deploy plan draft

UTC dates and times:

Monday early morning ~1:00 am:

  • be-prod
  • es-prod
  • de-prod
  • ie-prod
  • hu-prod not ready for deploy yet

Tuesday early morning ~1:00 am:

  • fr-prod
  • uk-prod

Tuesday morning ~6:00 am:

  • ca-prod
  • us-prod

Tuesday midday ~14:00 UTC:

  • au-prod
  • nz-prod

@dacook
Copy link
Member Author

dacook commented Jun 27, 2023

Two more instances deployed:

  • UK
  • FR

I had a quick look around and nothing seems amiss. On UK, I added to cart and proceeded to payment step, and also viewed the bulk products screen successfully. No bugsnag alerts. FR reported a momentary outage

Out of interest, UK's db migration took 64s, and FR 35s.

@dacook
Copy link
Member Author

dacook commented Jun 27, 2023

Deployed on:

@dacook
Copy link
Member Author

dacook commented Jun 27, 2023

It looks like the local time was 11pm for Canada, so in hindsight it would have been better to wait a few hours later.

@jibees, the planned time for AU is also 11pm local time, so I suggest we move it later. I think 14:00 UTC is 4pm your time, would that be ok for you?

@jibees
Copy link
Contributor

jibees commented Jun 27, 2023

14:00 UTC is fine for me as well!

@jibees
Copy link
Contributor

jibees commented Jun 27, 2023

I've edited the comment to:

Tuesday midday ~14:00 UTC:

@jibees
Copy link
Contributor

jibees commented Jun 27, 2023

A bit late, starting at 14:45 UTC.

@jibees
Copy link
Contributor

jibees commented Jun 27, 2023

Capture d’écran 2023-06-27 à 16 52 12 Capture d’écran 2023-06-27 à 16 59 48

@jibees jibees closed this as completed Jun 27, 2023
@mkllnk
Copy link
Member

mkllnk commented Jun 28, 2023

Well done, team! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants