Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vouchers, Reports] Taxes in reports are not correct, e.g. Sales Tax Totals By Order report #11364

Closed
drummer83 opened this issue Aug 8, 2023 · 3 comments · Fixed by #11543
Closed
Assignees
Labels
bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround.

Comments

@drummer83
Copy link
Contributor

Description

The values in the Sales Tax Totals By Order report are not correct. Other reports may be affected as well.

  • Discounts on taxes should be reflected in the tax column (= original tax minus tax discount).
  • Total without tax needs to be updated accordingly.
    image

Expected Behavior

Values in reports must be correct.

Actual Behaviour

Values in reports are not correct.

Steps to Reproduce

  1. Place an order with a voucher and taxes excluded from price.
  2. Render the report.
  3. Compare the numbers of the report to the numbers of the order in the back office.

Animated Gif/Screenshot

See above.

Workaround

Severity

Your Environment

  • Version used:
  • Browser name and version:
  • Operating System and version (desktop or mobile):

Possible Fix

@RachL RachL added the bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround. label Aug 18, 2023
@rioug rioug self-assigned this Sep 8, 2023
@rioug
Copy link
Collaborator

rioug commented Sep 14, 2023

I have a fix ready to go for "Sales Tax Totals By Order" report

I had a look "Sales Tax Totals By Producer" report as well, but if I understand correctly, this is a report from the producer point of view, so voucher discount don't apply here. And from what I could see it doesn't apply to the other reports either.
But let me know if I missed something.

@drummer83
Copy link
Contributor Author

Thanks, @rioug!
Let's move forward with this one and I will check the other reports when testing this one.
Sounds good?

@rioug
Copy link
Collaborator

rioug commented Sep 14, 2023

Sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants