Tax category error with file import

[tschumilas]

Description

It is not possible to change a tax category with the product import feature. This is not new. However, now a tax category error is generated when the import file is used a second time. The first import of the tax category is fine. Then, without changing the tax category, the second import of the same information generates an error. The app seems to think the tax category information has changed. This is new - all the users here in Canada who use the import tool (including myself) affirm that this started to happen very recently.

For someone with large product lists, using import should be a time saver. But now, the user needs to avoid this error by deleting the tax category for existing products in the import file, but leaving the tax category data in place for newly imported products.

Expected Behavior

If tax category data has not changed, there should be no error on import.

Actual Behaviour

There is an import error "Tax_category cannot be updated on existing products via product import" when the tax category information has not changed.

Steps to Reproduce

1. Create an import file with data in the Tax Category column
2. Import
3. Without changing any information in the file, try the import again
4. See the error - this file cannot be used to update information again unless the tax category data is removed.

Animated Gif/Screenshot

Workaround

Remove the tax category data from products that have already been imported, but leave it in the file for new products being imported.

Severity

bug-s3

bug-s1: a critical feature is broken: checkout, payments, signup, login
bug-s2: a non-critical feature is broken, no workaround
bug-s3: a feature is broken but there is a workaround
bug-s4: it's annoying, but you can use it
bug-s5: we can live with it, only a few users impacted

https://github.com/openfoodfoundation/openfoodnetwork/wiki/Bug-severity
-->

Your Environment

• Version used:
• Browser name and version:
• Operating System and version (desktop or mobile):

Possible Fix