Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUU] Saving and success message tweaks #11517

Closed
6 tasks done
mariocarabotta opened this issue Sep 11, 2023 · 3 comments
Closed
6 tasks done

[BUU] Saving and success message tweaks #11517

mariocarabotta opened this issue Sep 11, 2023 · 3 comments
Assignees

Comments

@mariocarabotta
Copy link
Collaborator

mariocarabotta commented Sep 11, 2023

This card builds on top of scenarios 7 and 8 of #11059

Saving overlay

  • blocking the table interface (but users will still be able to refresh or move to a different screen)
  • loading should be always visible even if I have scrolled below the fold. see this issue for more details on current behaviour. Also note that this specific behaviour might be overlapping with sticky table header, and sticky "products have changes" container, described here

Designs here > https://www.figma.com/file/v1zbrWDZSRd3Nqoe0SJ2Sm/Engineering-Delivery---Back-Office?type=design&node-id=657%3A3131&mode=design&t=M5n7m73a4MSXR9jQ-1
Screenshot 2023-09-11 at 10 23 18

Success message

  • temporary message docked at the bottom center of the page
  • can be dismissed by clicking the button
  • will dismiss automatically after 4 seconds
  • user can still interact with the screen interface

Designs here >> https://www.figma.com/file/v1zbrWDZSRd3Nqoe0SJ2Sm/Engineering-Delivery---Back-Office?type=design&node-id=658%3A3704&mode=design&t=M5n7m73a4MSXR9jQ-1
(Click ▶️ button at top-right to preview the workflow -- I had to log in for it to work)

Screenshot 2023-09-11 at 10 34 10

@mariocarabotta
Copy link
Collaborator Author

The overlay spinner can just say "Loading" and be used across different contexts

@abdellani abdellani removed their assignment Nov 28, 2023
@dacook dacook self-assigned this Nov 29, 2023
@mariocarabotta
Copy link
Collaborator Author

when testing styles across different pages, please add any messages with the wrong style / type in the issue below and they will be updated separately

#11884

@dacook
Copy link
Member

dacook commented Dec 14, 2023

Discussed with Mario; we don't need a specific "Saving" status, the current "Loading" message is sufficient and perhaps even preferable.
So all done!

@dacook dacook closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants