[Vouchers] The note regarding order total less than voucher amount shouldn't be displayed for percentage vouchers

[drummer83]

Description

The note 'Note: if your order total is less than your voucher you may not be able to spend the remaining value.' displayed at step 2 of checkout shouldn't be displayed for percentage vouchers because in this case it can't happen.

Steps to Reproduce

1. As an enterprise manager, Set up a percentage voucher on a shop (make sure the feature toggle "vouchers" is activated"
2. As a shopper, apply that voucher to step 2 of the checkout process - notice the message is not displayed
3. Retest with a non percentage voucher and check the message is showing up

Let's add an automated test for this

Severity

bug-s4: it's annoying, but you can use it

[lin-d-hop]

Confirmed papercut :)

[prateek0411999]

Hey @drummer83 - I'd like to work on this issue. Can I please get assigned to it? Thanks :)

[drummer83]

Of course, and welcome, @prateek0411999!
Looking forward to your contribution!
And don't hesitate to ping us if you get stuck.

[prateek0411999]

Hi @drummer83, I've raised a pull request for the same (#11694)

Let me know if any change is required in this

[drummer83]

Thank you, @prateek0411999!
Your pull request will now be reviewed by our developers and then tested. We will let you know!
Thanks again!

[rioug]

Hey @drummer83 , as far as I can see the problem you are describing shouldn't be happening right now. I have not been able to reproduce it, could you check again ? and if you manage to reproduce it, could you provide more detailed step to reproduce ?

I have a feeling this might have been an issue at some point, but it got resolved as part of another bug fix.

[prateek0411999]

Hey @rioug, As per my observation this issue is still persisted, i was able to reproduce the same as well that's why i've raised the PR.

[filipefurtad0]

Agree, this one is not clear how to reproduce... Below a percentage voucher is added, but no warning is displayed. This is before staging the associated PR:

Also the pic in the description displays a flat amount voucher. Any ideas?

Edit: got it now - order amount needs to be lower that the voucher percentage value.

[filipefurtad0]

Thanks @prateek0411999 - your spec documented it nicely 🙏