Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vouchers] Support mixed tax discounted by vouchers #11675

Open
mkllnk opened this issue Oct 16, 2023 · 0 comments
Open

[Vouchers] Support mixed tax discounted by vouchers #11675

mkllnk opened this issue Oct 16, 2023 · 0 comments
Labels
bug-s5 We can live with it... Few users are impacted. tech debt

Comments

@mkllnk
Copy link
Member

mkllnk commented Oct 16, 2023

Description

The voucher tax logic assumes that tax is either included in price or excluded from price across all line items of the discounted order. But multiple tax rates can apply to the same product and therefore one line item can have included and excluded tax. I even heard stories of that applying in real life in some countries. 🙃

Expected Behavior

If some line items have included and excluded tax then the applied voucher also has included and excluded tax respectively.

Actual Behaviour

If some line items have excluded tax then the voucher only looks as excluded tax and doesn't contain included tax.

Steps to Reproduce

  1. Create two tax rates, one included in price and one additional.
  2. Apply both tax rates to some products and some fees.
  3. Add items with and without tax to an order.
  4. Apply a voucher.
  5. Verify the calculations. Included and excluded tax should be displayed.

Animated Gif/Screenshot

Workaround

Severity

On a bug level it's only an s5 but this is also tech debt. I think that resolving this issue will make vouchers more robust and it will make testing easier with less confusion.

Your Environment

  • Version used:
  • Browser name and version:
  • Operating System and version (desktop or mobile):

Possible Fix

@RachL RachL added tech debt bug-s5 We can live with it... Few users are impacted. labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s5 We can live with it... Few users are impacted. tech debt
Projects
Status: All the things 💤
Development

No branches or pull requests

2 participants