[White label] [Trix editor] Console error when deleting logo while custom tab is active

[drummer83]

Description

This was found when testing #12271.

If the custom tab for white labelling is active and the white label logo is the removed, there is a console error and the page content is displayed twice.

Expected Behavior

Deleting the white label logo while the white label custom tab is active should work without errors.

Actual Behaviour

Deleting the white label logo while the white label custom tab is active shows a console error and the page content is displayed twice.

Steps to Reproduce

0. Activate your browser console (hit F12) in your browser and click on 'console'.
1. In enterprise settings go to White Label.
2. Activate 'Hide OFN navigation'.
3. Upload a logo.
4. Activate 'Create custom tab in shopfront'.
5. Enter a tab title.
6. Enter a tab content.
7. Click 'Update'.
8. In enterprise settings go to White Label again.
9. Remove the logo and confirm the confirmation dialog.
10. Observe the Trix error in the console.
11. Observe that the page content is dispayed twice.

Animated Gif/Screenshot

Browser console error:

Duplicated content:

Workaround

Refresh the page to remove the duplicate content.

Severity

bug-s4: it's annoying, but you can use it

Your Environment

• Version used: staged set variant_processor to mini_magick #12271
• Browser name and version: Firefox 123.0.1 (64-Bit)
• Operating System and version (desktop or mobile): Windows 11, Desktop

Possible Fix

[MrBowmanXD]

Began to investigate this issue. In app/webpacker/controllers/trixeditor_controller.js:line 25 if we check for this.element.toolbarElement first (with a if clause) we can make the error disappear but i still see repeated content, will investigate a bit more.

[MrBowmanXD]

Will probably need to check the logic behind the removal of the logo, because the content is repeated when the logo is removed.