Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.4.54 Feijoada #12607

Closed
12 tasks done
dacook opened this issue Jun 25, 2024 · 1 comment
Closed
12 tasks done

Release v4.4.54 Feijoada #12607

dacook opened this issue Jun 25, 2024 · 1 comment
Assignees

Comments

@dacook
Copy link
Member

dacook commented Jun 25, 2024

1. Preparation on Thursday

  • Merge pull requests in the Ready To Go column
  • Include translations: script/release/update_locales
  • Increment version number: git push upstream HEAD:refs/tags/vX.Y.Z
    • Major: if server changes are required (eg. provision with ofn-install)
    • Minor: larger change that is irreversible (eg. migration deleting data)
    • Patch: all others. Shortcut: script/release/tag
  • Draft new release. Look at previous releases for inspiration.
    • Select new release tag
    • Generate release notes and check to ensure all items are arranged in the right category.
  • Notify #instance-managers of user-facing 👀, API ⚠️ and experimental 🚧 changes.

2. Testing

3. Finish on Tuesday

  • Publish and notify #global-community (this is automatically posted with a plugin)
  • Deploy the new release to all managed instances.
    Command line instructions
    cd ofn-install
    git pull
    ansible-playbook --limit all_prod --extra-vars "git_version=vX.Y.Z" playbooks/deploy.yml
    
  • Notify #instance-managers:

    @instance_managers The new release has been deployed.

  • Create issue for next release and confirm with next release manager in #core-devs.

The full process is described at https://github.com/openfoodfoundation/openfoodnetwork/wiki/Releasing.

@rioug rioug self-assigned this Jun 25, 2024
@rioug rioug changed the title Release Release v4.4.54 Feijoada Jun 26, 2024
@drummer83 drummer83 added pr-staged-au staging.openfoodnetwork.org.au and removed pr-staged-au staging.openfoodnetwork.org.au labels Jun 26, 2024
@drummer83
Copy link
Contributor

Hi @dacook and @rioug,

Thanks for preparing the release. I couldn't find any issue with it. Notes are here: https://docs.google.com/document/d/1K5teCnrpqLIC6gzxB1mv9JkXxaHqZF73wSIMJShjBAI/edit?usp=sharing

I did come along one thing, but it's been there in the previous version as well: Checking out on my mobile phone (Fairphone 5 powered by Android) doesn't allow me to complete the order on step 3 when the page is scrolled down a bit (not fully up, not fully down, but somewhere in between). I figured out that I have to touch above the button (where the terms of service are linked roughly)!
What do you think, is this an issue on our end? Is it a Firefox thing? I couldn't reproduce it on a Galaxy 22 in Browserstack. Maybe you can try on your phones and let me know if we need an issue for that. But again, it's not introduced in this release.

We're ready to go here. Thanks again! 🚀

@drummer83 drummer83 self-assigned this Jun 26, 2024
@drummer83 drummer83 added pr-staged-au staging.openfoodnetwork.org.au and removed pr-staged-au staging.openfoodnetwork.org.au labels Jun 26, 2024
@mkllnk mkllnk closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants