Missing translations in all.js

[mkllnk]

@lin-d-hop encountered a broken sign-up form on the UK production server. It seems related to some missing translations in the compiled all.js file. We see the same on the Australian production server, but our sign-up form is working. From the file:

<span class=\"translation_missing\" title=\"translation missing: en-GB.spree.firstname\">Firstname</span>

There are eight translation missing errors in that file.

The visible errors on the UK production servers come from missing translations within Javascript.

[missing "en.welcome_to_ofn" translation]

These are generated by i18n-js which is looking for en translations while the en-GB locale is included in the all.js asset file.

This could be related to the new i18n-js gem introduced in #1564, but it could also be a configuration issue on the UK server.

[daniellemoorhead]

Ping @lin-d-hop @Matt-Yorkley @sineadfenton

[lin-d-hop]

Thanks for looking into this @mkllnk. Personally I am still stumped. So is @Matt-Yorkley.

Since this is affecting no other servers I think UK configuration is not playing nice with the new i18n-js gem. Definitely not solved by rebuilding assets, clearing cache etc.

[lin-d-hop]

@Matt-Yorkley also tried some things on UK staging in this PR
#1757

[sineadfenton]

Translation Text

[jeronimo]

Ok. So the problem is that registration page uses different layout which does not include

partial _i18n_script.html.haml

It exists in darkswarm and admin layouts

But not the one that is used in registration.

Quick fix: deploy server with default_locale: en.
Normal fix: Add i18n-js related code to Spree generated layouts.

[lin-d-hop]

Officially fixed by @jeronimo
#1765

Just for clarity:
#1764 is a patch for v1.8.13.
#1765 is on current master

Since no one else is experiencing the problem it is probably fine to just make sure #1765 is merged before the next release.

Thanks everyone for putting the time in to fix this. This has been stressing me out for a week!

[mkllnk]

Great. That fix for the registration got merged. But there are still missing translations in the all.js file. There have been no reports to visible issues yet, but it is something that should be fixed. So I'm not closing this yet.

[daniellemoorhead]

@mkllnk I assume this can't be closed yet due to the remaining translations not being done yet? If this is the case can you please change the milestone to September? Thanks.

[mkllnk]

True, this still needs fixing, but at least all visible issues are fixed.

[daniellemoorhead]

REMAINING TO BE DONE FOR THIS ISSUE:

...there are still missing translations in the all.js file. There have been no reports to visible issues yet, but it is something that should be fixed.

[daniellemoorhead]

@sigmundpetersen did you check what @myriamboure suggested above?

I'd like to triage this issue, and either move it back into the backlog or ensure that it's being worked on and therefore worthy of sitting in the Code Review column.

Next steps for this?

[myriamboure]

@daniellemoorhead this was fixed and has nothing to do with this PR I think so I deleted the posts. Don't need to have a look @sigmundpetersen it's all good :-) Still we need to know how to move that forward. Should we close this and open a better specified bug issue? It seems this one was open for something specific to uk that were fixed. If there is no visible error, do we need to keep it open? Or wait for the need to be here to fix it? @mkllnk

[mkllnk]

I think we should open a new issue with low priority for the remaining missing translations and close this one.

[myriamboure]

I guess a dev who have access to the code should do it @mkllnk right? Cause as a user I have no idea what those missing translations refer to. Can you do it quickly? Else point someone else who can ;-)

[mkllnk]

I had another look and couldn't find any missing translations in the sign-up form. I'll close this one and we can open a new issue if we come across it.