Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No banner shows up when successfully deleting a shipping method #2881

Open
HugsDaniel opened this issue Oct 17, 2018 · 2 comments
Open

No banner shows up when successfully deleting a shipping method #2881

HugsDaniel opened this issue Oct 17, 2018 · 2 comments
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.

Comments

@HugsDaniel
Copy link
Contributor

Description

When a shipping_method is deleted, the banner confirming the deletion doesn't show up in browser. It shows up in feature test though.

Expected Behavior

When successfully deleting a shipping method, a banner should show up.

Actual Behavior

The banner doesn't show up in browser.

Steps to Reproduce

  1. Go to Configuration -> Shipping Methods
  2. Delete one shipping method
  3. See no banner with successful message

Possible Fix

It shows up on feature tests, that would be a clue.
@HugsDaniel HugsDaniel self-assigned this Oct 17, 2018
@HugsDaniel HugsDaniel mentioned this issue Oct 17, 2018
Closed
@sigmundpetersen sigmundpetersen changed the title [Spree upgrade] No banner shows up when successfully deleting a shipping method [Spree Upgrade] No banner shows up when successfully deleting a shipping method Oct 18, 2018
@sigmundpetersen
Copy link
Contributor

This doesn't work in master either, should we detach from Spree Upgrade @luisramos0 ?

Hint: I did see the banner when leaving the page, going to whatever other menu in backoffice

@luisramos0 luisramos0 added the bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. label Feb 13, 2019
@luisramos0 luisramos0 changed the title [Spree Upgrade] No banner shows up when successfully deleting a shipping method No banner shows up when successfully deleting a shipping method Feb 13, 2019
@luisramos0
Copy link
Contributor

nice catch @sigmundpetersen ! yes, let's make it a normal s4 bug.

This was referenced Jan 20, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.
Projects
OFN Delivery board
Status: All the things
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sigmundpetersen @luisramos0 @HugsDaniel