Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When duplicating a product, image is not shown in the duplicate product straight away, needs refresh #3298

Closed
myriamboure opened this issue Jan 9, 2019 · 4 comments
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround.

Comments

@myriamboure
Copy link
Contributor

myriamboure commented Jan 9, 2019

Description

When I duplicate a product with an image, the copy is created but the image seems not to be duplicated as it is not displayed:
capture du 2019-01-09 09-42-59

But when I refresh the page, I realize the images have actually been copied correctly:
capture du 2019-01-09 09-46-02

Also sometimes if many data for the user account, the duplication takes time, it is confusing we have the impression it is not working.

Expected Behavior

When I duplicate a product with an image, the new line shows straight away the image.
During the duplication time, a loader is displayed.

Actual Behavior

It doesn't.

Steps to Reproduce

  1. Go to products, duplicate a product with an image, you see the new line has no image.
  2. Refresh, and see the image has appeared.

Context

Remaining bug after fixing #2756

Severity

I would say S3, the feature is not broken, but the UX is very broken, it is very confusing for the user.

Your Environment

  • Version used: v1.24
  • Browser name and version: Firefox
  • Operating System and version (desktop or mobile): Ubuntu 18.1
@myriamboure myriamboure added the bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. label Jan 9, 2019
@RachL
Copy link
Contributor

RachL commented Jan 9, 2019

@myriamboure can we take the opportunity in this issue to add a loader when clicking on duplicate? I find it confusing to click on duplicate and then not know that something is happening...

@myriamboure
Copy link
Contributor Author

myriamboure commented Jan 9, 2019

I added that @RachL in the description but I'm wondering if those two things shouldn't be two separate issues ? I think it should. It is less priority as affecting mostly super admin only for now I guess.

@RachL
Copy link
Contributor

RachL commented Jan 9, 2019

Let's maybe see with a dev. Because if we remove the refresh IMO we need a loader

@RachL
Copy link
Contributor

RachL commented Sep 10, 2020

This is working now 🎉 Closing

@RachL RachL closed this as completed Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround.
Projects
None yet
Development

No branches or pull requests

2 participants