Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert class ScopeVariantsForSearch to a service class #3519

Open
luisramos0 opened this issue Feb 19, 2019 · 0 comments
Open

Convert class ScopeVariantsForSearch to a service class #3519

luisramos0 opened this issue Feb 19, 2019 · 0 comments

Comments

@luisramos0
Copy link
Contributor

What we should change and why (this is tech debt)

We should convert ScopeVariantsForSearch into a simple service class called something like VariantsSearchService. This class is not "scoping" variants to hubs as ScopeVariantToHub but rather doing a very normal search with filters on variants and, in the process, it also scopes the variants using ScopeVariantsToHub. It just a matter of a bad name for the class that is very misleading. This code should also be moved from /lib to app/services.
This should be done so the code becomes better organized and simpler.
I am not sure there is a tech debt issue for it but as we do this we should think about how to remove subscritptions logic from the core search functionality in OFN.

Context

This came up in #3172

Impact and timeline

This is not critical but because it's a central piece of the OFN codebase it deserves some attention. As OFN and its API grows, catalog search will become more important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: All the things
Development

No branches or pull requests

1 participant